Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct a typo #29207

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: correct a typo #29207

merged 1 commit into from
Dec 16, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 13, 2024

Description

Open in GitHub Codespaces

This PR fixes a typo that uses a non existent field on an object.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@infiniteflower infiniteflower marked this pull request as ready for review December 13, 2024 20:28
@infiniteflower infiniteflower requested a review from a team as a code owner December 13, 2024 20:28
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b6dc010]
Page Load Metrics (1682 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22618681614327157
domContentLoaded1528181416547536
load1565186816827837
domInteractive237344168
backgroundConnect106526189
firstReactRender1572402412
getState55314147
initialActions01000
loadScripts1159141812677134
setupStore65913157
uiStartup17752265192111756
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -4 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@infiniteflower infiniteflower added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 6c4cc0e Dec 16, 2024
92 checks passed
@infiniteflower infiniteflower deleted the fix/xchain-gas-typo branch December 16, 2024 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants