-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: center backup toast #29200
feat: center backup toast #29200
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [b4cdc8f]
Page Load Metrics (1618 ± 88 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: CSS for Content Container
Strengths:
- Good use of border-radius: The border-radius: 8px; property adds a modern and sleek appearance to the element. This is a great choice for improving the visual appeal.
- Responsive sizing: The use of calc(100% - 16px) for width ensures the element adapts to its parent container while maintaining consistent padding. This approach balances flexibility and design consistency.
- Flex layout: The display: flex; property on &__content-container is an excellent choice for creating flexible and responsive layouts, enabling better alignment and spacing of child elements.
- Max-width defined: The max-width: 472px prevents the container from becoming too large on wider screens, maintaining a clean and readable design.
Suggestions: - Add comments: Adding comments about the purpose of specific properties (e.g., why you chose max-width: 472px) can help others understand your intent.
- Consider accessibility: Ensure that the padding and dimensions work well for users with accessibility needs, especially if the content inside involves text or interactive elements.
- Variable usage: If you're using a CSS preprocessor (e.g., SCSS), consider using variables for values like 16px, 8px, and 472px to maintain consistency and simplify future adjustments.
- Add fallback for older browsers: If browser support is a concern, double-check compatibility for calc() and flex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Centers the backup warning toast
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist