Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: center backup toast #29200

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: center backup toast #29200

merged 1 commit into from
Dec 18, 2024

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Dec 13, 2024

Description

Centers the backup warning toast

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-12-13 at 14 54 15

After

Screenshot 2024-12-13 at 14 53 25 Screenshot 2024-12-13 at 14 53 36

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b4cdc8f]
Page Load Metrics (1618 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13812100161818287
domContentLoaded13452085159418388
load13812101161818388
domInteractive236639136
backgroundConnect76824189
firstReactRender1580352512
getState45913147
initialActions01000
loadScripts9891578119415675
setupStore66315199
uiStartup158124121867229110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: CSS for Content Container
Strengths:

  1. Good use of border-radius: The border-radius: 8px; property adds a modern and sleek appearance to the element. This is a great choice for improving the visual appeal.
  2. Responsive sizing: The use of calc(100% - 16px) for width ensures the element adapts to its parent container while maintaining consistent padding. This approach balances flexibility and design consistency.
  3. Flex layout: The display: flex; property on &__content-container is an excellent choice for creating flexible and responsive layouts, enabling better alignment and spacing of child elements.
  4. Max-width defined: The max-width: 472px prevents the container from becoming too large on wider screens, maintaining a clean and readable design.
    Suggestions:
  5. Add comments: Adding comments about the purpose of specific properties (e.g., why you chose max-width: 472px) can help others understand your intent.
  6. Consider accessibility: Ensure that the padding and dimensions work well for users with accessibility needs, especially if the content inside involves text or interactive elements.
  7. Variable usage: If you're using a CSS preprocessor (e.g., SCSS), consider using variables for values like 16px, 8px, and 472px to maintain consistency and simplify future adjustments.
  8. Add fallback for older browsers: If browser support is a concern, double-check compatibility for calc() and flex.

@EtherWizard33 EtherWizard33 self-requested a review December 18, 2024 15:11
Copy link

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonybur jonybur added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@jonybur jonybur added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit fd9eb48 Dec 18, 2024
86 checks passed
@jonybur jonybur deleted the jb-center-backup-toast branch December 18, 2024 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants