-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: quote timeout treatment for bridging #29172
Merged
Merged
+145
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghgoodreau
previously approved these changes
Dec 12, 2024
infiniteflower
previously approved these changes
Dec 12, 2024
Builds ready [daff923]
Page Load Metrics (1375 ± 44 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
force-pushed
the
mb894-style-quotes-1
branch
2 times, most recently
from
December 16, 2024 19:16
b23db36
to
19a741d
Compare
micaelae
force-pushed
the
mb894-style-quotes-1
branch
from
December 16, 2024 19:43
19a741d
to
8e5786b
Compare
micaelae
dismissed stale reviews from infiniteflower and ghgoodreau
December 16, 2024 22:41
The base branch was changed.
micaelae
force-pushed
the
bridge-timeout-refresh
branch
from
December 16, 2024 23:32
daff923
to
a27e664
Compare
Builds ready [a27e664]
Page Load Metrics (1669 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ghgoodreau
approved these changes
Dec 17, 2024
infiniteflower
approved these changes
Dec 17, 2024
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when the quote is older than 30s
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Pre-merge author checklist
Pre-merge reviewer checklist