Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: quote timeout treatment for bridging #29172

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Dec 12, 2024

Description

when the quote is older than 30s

  • if the user has sufficient balance, hide quote and show a button that restarts polling on click
  • if the user doesn't have sufficient balance, keep showing the quote quote but display a button that restarts polling on click

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Request quotes
  2. Wait for ~3 minutes after fetching starts
  3. Quote should time out
  4. Clicking the Fetch button should restart polling

Screenshots/Recordings

Before

N/A

After

Screenshot 2024-12-12 at 1 50 40 PM
Screenshot 2024-12-12 at 1 46 18 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae marked this pull request as ready for review December 12, 2024 22:08
@micaelae micaelae requested a review from a team as a code owner December 12, 2024 22:08
ghgoodreau
ghgoodreau previously approved these changes Dec 12, 2024
infiniteflower
infiniteflower previously approved these changes Dec 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [daff923]
Page Load Metrics (1375 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37815921324235113
domContentLoaded1241158513679144
load1256159213759144
domInteractive17512973
backgroundConnect8151021
firstReactRender15381952
getState48510
initialActions00000
loadScripts909116410017436
setupStore611821
uiStartup13581760152110952
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 360 Bytes (0.01%)
  • ui: 18.22 KiB (0.23%)
  • common: 3.32 KiB (0.04%)

@micaelae micaelae force-pushed the mb894-style-quotes-1 branch 2 times, most recently from b23db36 to 19a741d Compare December 16, 2024 19:16
@micaelae micaelae requested a review from a team as a code owner December 16, 2024 19:16
@micaelae micaelae force-pushed the mb894-style-quotes-1 branch from 19a741d to 8e5786b Compare December 16, 2024 19:43
Base automatically changed from mb894-style-quotes-1 to main December 16, 2024 22:41
@micaelae micaelae dismissed stale reviews from infiniteflower and ghgoodreau December 16, 2024 22:41

The base branch was changed.

@micaelae micaelae force-pushed the bridge-timeout-refresh branch from daff923 to a27e664 Compare December 16, 2024 23:32
@metamaskbot
Copy link
Collaborator

Builds ready [a27e664]
Page Load Metrics (1669 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14642104166715273
domContentLoaded14192062163715273
load14652105166915273
domInteractive18146392713
backgroundConnect115833188
firstReactRender1697373014
getState56818209
initialActions01000
loadScripts10641662123413766
setupStore674212412
uiStartup165224322006242116
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 435 Bytes (0.01%)
  • common: 108 Bytes (0.00%)

@micaelae micaelae removed the request for review from a team December 17, 2024 01:14
@micaelae micaelae added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 6fe17a0 Dec 17, 2024
77 checks passed
@micaelae micaelae deleted the bridge-timeout-refresh branch December 17, 2024 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants