chore: low return warning alert for bridging #29171

micaelae · 2024-12-12T21:41:29Z

Description

Changes the Low Return tooltip into an alert Banner, and highlights network fee in the quote card

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1814

Manual testing steps

Request quotes with a low return
Verify that new treatment is shown

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-12-12T22:42:30Z

Builds ready [4a85e56]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1432 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	250	2025	1313	383	184
		domContentLoaded	1258	2017	1423	169	81
		load	1267	2027	1432	169	81
		domInteractive	24	106	38	22	11
		backgroundConnect	6	17	10	2	1
		firstReactRender	15	25	19	3	2
		getState	4	17	6	3	1
		initialActions	0	1	0	0	0
		loadScripts	899	1447	1036	131	63
		setupStore	6	10	8	1	1
		uiStartup	1396	2155	1580	179	86

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 360 Bytes (0.01%)
ui: 18.4 KiB (0.23%)
common: 3.17 KiB (0.04%)

The base branch was changed.

metamaskbot · 2024-12-17T00:15:28Z

Builds ready [34b084b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1768 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1431	2147	1771	202	97
		domContentLoaded	1417	2085	1745	198	95
		load	1428	2145	1768	201	97
		domInteractive	24	70	39	15	7
		backgroundConnect	9	68	24	20	10
		firstReactRender	16	97	46	28	14
		getState	4	79	21	22	10
		initialActions	0	1	0	0	0
		loadScripts	1003	1548	1281	144	69
		setupStore	6	61	20	20	10
		uiStartup	1713	2852	2065	314	151

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 434 Bytes (0.01%)
common: -43 Bytes (-0.00%)

infiniteflower

The lack of horizontal padding around the yellow highlight looks a bit strange.

micaelae · 2024-12-17T18:16:58Z

The lack of horizontal padding around the yellow highlight looks a bit strange.

What do you think of highlighting the entire row? This is what we had in V1

metamaskbot · 2024-12-17T19:24:00Z

Builds ready [38c21c3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1625 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	252	1847	1562	311	149
		domContentLoaded	1470	1759	1596	63	30
		load	1479	1774	1625	70	34
		domInteractive	25	78	37	16	8
		backgroundConnect	9	77	36	24	11
		firstReactRender	16	100	36	28	13
		getState	4	50	12	10	5
		initialActions	0	1	0	0	0
		loadScripts	1087	1341	1187	60	29
		setupStore	6	74	18	20	10
		uiStartup	1698	2293	1900	143	69

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 326 Bytes (0.00%)
common: -43 Bytes (-0.00%)

metamaskbot · 2024-12-18T21:12:25Z

Builds ready [7eed8fb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1676 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1463	2293	1687	185	89
		domContentLoaded	1429	2234	1650	173	83
		load	1462	2293	1676	184	89
		domInteractive	18	88	37	22	11
		backgroundConnect	8	55	25	16	8
		firstReactRender	15	73	39	24	12
		getState	4	64	12	15	7
		initialActions	0	1	0	0	0
		loadScripts	1050	1754	1242	156	75
		setupStore	6	54	11	12	6
		uiStartup	1658	2450	1880	180	87

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 326 Bytes (0.00%)
common: -43 Bytes (-0.00%)

metamaskbot added the team-bridge label Dec 12, 2024

micaelae marked this pull request as ready for review December 12, 2024 21:43

micaelae requested a review from a team as a code owner December 12, 2024 21:43

jclancy93 previously approved these changes Dec 12, 2024

View reviewed changes

infiniteflower previously approved these changes Dec 12, 2024

View reviewed changes

micaelae force-pushed the mb894-style-quotes-1 branch 2 times, most recently from b23db36 to 19a741d Compare December 16, 2024 19:16

micaelae requested a review from a team as a code owner December 16, 2024 19:16

micaelae force-pushed the mb894-style-quotes-1 branch from 19a741d to 8e5786b Compare December 16, 2024 19:43

Base automatically changed from mb894-style-quotes-1 to main December 16, 2024 22:40

micaelae force-pushed the mms1814-low-return branch from 4a85e56 to 48ee58b Compare December 16, 2024 23:18

ghgoodreau previously approved these changes Dec 17, 2024

View reviewed changes

infiniteflower reviewed Dec 17, 2024

View reviewed changes

micaelae force-pushed the mms1814-low-return branch from 34b084b to 5569c60 Compare December 17, 2024 17:30

micaelae dismissed ghgoodreau’s stale review via 38c21c3 December 17, 2024 18:52

infiniteflower approved these changes Dec 17, 2024

View reviewed changes

micaelae added 8 commits December 18, 2024 12:40

chore: update low return threshold

ff9e8f1

fix: quotes modal padding

b0b1b11

chore: new Low Return treatment

0d65b0c

fix: selector unit tests

6f26ce5

fix: snapshots

db1a8a0

chore: highlight full network fees row

23398f2

fix: bridge page stories

52d554f

chore: condense network fees when shown in native currency

0a8c0a6

fix: snapshots

7eed8fb

micaelae force-pushed the mms1814-low-return branch from 38c21c3 to 7eed8fb Compare December 18, 2024 20:40

ghgoodreau approved these changes Dec 19, 2024

View reviewed changes

micaelae added this pull request to the merge queue Dec 19, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024

micaelae added this pull request to the merge queue Dec 19, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024

micaelae added this pull request to the merge queue Dec 19, 2024

Merged via the queue into main with commit cd39d7b Dec 19, 2024
77 checks passed

micaelae deleted the mms1814-low-return branch December 19, 2024 19:27

github-actions bot locked and limited conversation to collaborators Dec 19, 2024

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: low return warning alert for bridging #29171

chore: low return warning alert for bridging #29171

micaelae commented Dec 12, 2024 •

edited

Loading

metamaskbot commented Dec 12, 2024

metamaskbot commented Dec 17, 2024

infiniteflower left a comment

micaelae commented Dec 17, 2024

metamaskbot commented Dec 17, 2024

metamaskbot commented Dec 18, 2024

chore: low return warning alert for bridging #29171

chore: low return warning alert for bridging #29171

Conversation

micaelae commented Dec 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Dec 12, 2024

metamaskbot commented Dec 17, 2024

infiniteflower left a comment

Choose a reason for hiding this comment

micaelae commented Dec 17, 2024

metamaskbot commented Dec 17, 2024

metamaskbot commented Dec 18, 2024

micaelae commented Dec 12, 2024 •

edited

Loading