-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metametrics events to carousel #29141
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [993b969]
Page Load Metrics (1916 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the events seem to be working except BannerCloseAll
. It's not being dispatched
https://github.com/user-attachments/assets/fbe65e96-75b6-4f4b-815e-ffd250934146
…tension into jb-carousel-metrics
Builds ready [8f5a4ab]
Page Load Metrics (1543 ± 75 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR introduces tracking metrics for banners in the carousel to monitor their effectiveness. The following events are added:
Tracking Implementation Details:
Banner selected
When a banner or button in a banner is clicked:
Close all banners
When the last banner in the carousel is closed:
Banner shown
When a banner is displayed in the carousel:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3764
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist