Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: design related fixes in confirmation pages #29137

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 12, 2024

Description

Small design related fixes in re-designed confirmation pages

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3478

Manual testing steps

  1. Go to test dapp
  2. Submit transaction pages and check design fixes

Screenshots/Recordings

Screenshot 2024-12-12 at 6 52 03 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 12, 2024
@jpuri jpuri requested a review from a team as a code owner December 12, 2024 13:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge December 12, 2024 13:46
@metamaskbot
Copy link
Collaborator

Builds ready [b660655]
Page Load Metrics (1690 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14321893168810349
domContentLoaded14241839166110249
load1488185916909546
domInteractive237343189
backgroundConnect86326168
firstReactRender16103362713
getState57618209
initialActions01000
loadScripts1007139912449244
setupStore66716199
uiStartup16232499198218689
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 49a7c82 Dec 12, 2024
83 checks passed
@jpuri jpuri deleted the confirm_page_fixes branch December 12, 2024 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants