Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new metric sending_value to Transaction * events #29134

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Dec 12, 2024

Description

Adds a useSendingValueMetric hook that uses updateTransactionEventFragment to add the sending_value property on erc20 and native token transfers. The value is sent as an unformatted decimal javascript number.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3784

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Native token send:
Screenshot 2024-12-12 at 11 40 43

ERC20 token send:
Screenshot 2024-12-12 at 11 41 47

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Dec 12, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Dec 12, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner December 12, 2024 11:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3784 branch 2 times, most recently from f2fcccd to e861d94 Compare December 12, 2024 11:49
jpuri
jpuri previously approved these changes Dec 12, 2024
OGPoyraz
OGPoyraz previously approved these changes Dec 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [30e8388]
Page Load Metrics (1593 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28818491533308148
domContentLoaded14021841156811756
load14111850159311857
domInteractive237641168
backgroundConnect96529178
firstReactRender1592382713
getState4471094
initialActions01000
loadScripts1044140811909747
setupStore671192110
uiStartup16312223188415976
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.42 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 2e941a8 Dec 12, 2024
77 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3784 branch December 12, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants