Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert gridplus sdk version bumps #29125

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Dec 12, 2024

Description

This PR reverts #27973 and #28008, and then forces an secp256k1 resolution to deal with a yarn audit failure. This is necessary to fix typed message signing with the lattice gridplus hardware wallet.

All of this had been done on release branches and master in the past, when it should have been done directly on develop.

We do want to restore the #27973 and #28008 changes soon, but that requires getting to root of why those changes result in typed message signing failure with lattice griduplus

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Test "Sign Typed Message" v4 in the test dapp with a gridplus hardware wallet. It should succeed without error

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm
Copy link
Contributor Author

danjm commented Dec 12, 2024

@metamaskbot update-policies

@danjm danjm changed the title Revert gridplus sdk version bumps fix: Revert gridplus sdk version bumps Dec 12, 2024
Copy link

socket-security bot commented Dec 12, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/@noble/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@noble/[email protected], npm/@scure/[email protected], npm/@scure/[email protected], npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/[email protected], npm/[email protected], npm/@ethereumjs/[email protected], npm/@ethereumjs/[email protected], npm/[email protected], npm/[email protected], npm/@scure/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@danjm danjm force-pushed the revert-gridplus-sdk-version-bumps branch from 25d3f5f to da69a37 Compare December 12, 2024 09:12
@danjm
Copy link
Contributor Author

danjm commented Dec 12, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@danjm danjm force-pushed the revert-gridplus-sdk-version-bumps branch from 1f2ee49 to 58c920b Compare December 12, 2024 09:35
@danjm
Copy link
Contributor Author

danjm commented Dec 12, 2024

@SocketSecurity ignore-all

The new author is known and cryptographic operations within the gridplus sdk are to be expected

@danjm danjm force-pushed the revert-gridplus-sdk-version-bumps branch from 58c920b to c4da755 Compare December 12, 2024 09:59
@danjm
Copy link
Contributor Author

danjm commented Dec 12, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@vivek-consensys
Copy link

Working as expected, tested by completing sign transactions using test-dapp.
See recording here:

Screen.Recording.2024-12-12.at.14.18.48.mov

@danjm danjm marked this pull request as ready for review December 12, 2024 10:42
@danjm danjm requested review from a team as code owners December 12, 2024 10:42
@metamaskbot
Copy link
Collaborator

Builds ready [abeca18]
Page Load Metrics (1788 ± 193 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46729411670440211
domContentLoaded140528321755393189
load141028881788402193
domInteractive237343157
backgroundConnect7136373015
firstReactRender1685382412
getState54615147
initialActions00000
loadScripts103823201316343165
setupStore76511136
uiStartup161432062013449216
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 219.8 KiB (4.18%)
  • ui: -252 Bytes (-0.00%)
  • common: -67.32 KiB (-0.83%)

@danjm danjm added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 2e8ef02 Dec 12, 2024
77 checks passed
@danjm danjm deleted the revert-gridplus-sdk-version-bumps branch December 12, 2024 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants