fix: token detection across multiple networks

[bergeron]

Description

Fixes an issue where even though 'popular networks' was selected in the token filter, it was only showing detected tokens on the current network.

There were various places checking for Object.keys(tokenNetworkFilter).length === Object.keys(allNetworks).length, which is no longer an accurate way to check the state of the filter, since it's now been narrowed to only include popular networks. The selector getIsTokenNetworkFilterEqualCurrentNetwork is used instead.

Related issues

Fixes:

Manual testing steps

1. Onboard a wallet with tokens across chains
2. When token filter is on 'popular networks', it should show # of detected tokens across chains
3. When token filter is on current network, it should show # of detected tokens on current chain

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [9472a20]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1784 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	308	2297	1696	362	174
		domContentLoaded	1567	2237	1752	171	82
		load	1576	2256	1784	177	85
		domInteractive	22	67	39	14	7
		backgroundConnect	9	100	33	24	12
		firstReactRender	18	100	46	26	12
		getState	5	71	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1173	1729	1305	133	64
		setupStore	6	11	9	1	1
		uiStartup	1757	2492	2012	231	111

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -550 Bytes (-0.01%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [c46fc88]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1819 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1590	2354	1820	187	90
		domContentLoaded	1568	2340	1794	187	90
		load	1590	2346	1819	187	90
		domInteractive	26	83	41	17	8
		backgroundConnect	8	75	23	20	10
		firstReactRender	15	83	43	26	13
		getState	5	61	17	17	8
		initialActions	0	0	0	0	0
		loadScripts	1153	1807	1345	165	79
		setupStore	6	57	11	11	5
		uiStartup	1753	2628	2019	209	100

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -550 Bytes (-0.01%)
• common: 0 Bytes (0.00%)