Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (MMS-1789) bridge api called when external services disabled #29077

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Dec 10, 2024

Description

Bridge API gets called even when all privacy toggles are disabled:

https://bridge.api.cx.metamask.io/getAllFeatureFlags

Open in GitHub Codespaces

Related issues

Fixes: checks if external services are enabled (Basic Functionality toggle) before calling this API in the useBridging hook.

Manual testing steps

  1. Start onboarding through the MetaMask wallet.
  2. During onboarding, toggle the security feature 'Basic Functionality' OFF.
  3. Observe network calls to ensure this endpoint is not hit.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ghgoodreau
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ghgoodreau ghgoodreau changed the title fix: (MMS-1789) bridge api being when external services disabled fix: (MMS-1789) bridge api called when external services disabled Dec 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f8dfd52]
Page Load Metrics (1944 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint42624941776478230
domContentLoaded161224221922222106
load162324421944225108
domInteractive26523684
backgroundConnect105929168
firstReactRender158824168
getState801621212110
initialActions01000
loadScripts12461981150419895
setupStore620942
uiStartup187228232244296142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 49 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ghgoodreau ghgoodreau marked this pull request as ready for review December 11, 2024 01:42
@ghgoodreau ghgoodreau added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@ghgoodreau ghgoodreau requested a review from a team as a code owner December 11, 2024 23:52
@ghgoodreau ghgoodreau enabled auto-merge December 11, 2024 23:52
@metamaskbot
Copy link
Collaborator

Builds ready [293f263]
Page Load Metrics (1628 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14562030163416881
domContentLoaded14352007159716077
load14542080162817785
domInteractive238140168
backgroundConnect7101282512
firstReactRender15101443216
getState473222311
initialActions01000
loadScripts10601571119413565
setupStore67914188
uiStartup162625521973323155
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 49 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ghgoodreau ghgoodreau added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@ghgoodreau ghgoodreau added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 0a790f5 Dec 12, 2024
77 checks passed
@ghgoodreau ghgoodreau deleted the MMS-1789-bridge-api-privacy-regression-fix branch December 12, 2024 03:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants