-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (MMS-1789) bridge api called when external services disabled #29077
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabled from basic functionality toggle
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
ghgoodreau
changed the title
fix: (MMS-1789) bridge api being when external services disabled
fix: (MMS-1789) bridge api called when external services disabled
Dec 10, 2024
Builds ready [f8dfd52]
Page Load Metrics (1944 ± 108 ms)
Bundle size diffs
|
micaelae
approved these changes
Dec 11, 2024
jclancy93
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 11, 2024
Builds ready [293f263]
Page Load Metrics (1628 ± 85 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
metamaskbot
added
the
release-12.10.1
Issue or pull request that will be included in release 12.10.1
label
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.10.1
Issue or pull request that will be included in release 12.10.1
team-bridge
team-swaps
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bridge API gets called even when all privacy toggles are disabled:
https://bridge.api.cx.metamask.io/getAllFeatureFlags
Related issues
Fixes: checks if external services are enabled (Basic Functionality toggle) before calling this API in the useBridging hook.
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist