Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token.icon possibly null, update validators and types #29065

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 10, 2024

Description

Open in GitHub Codespaces

This PR fixes an issue where token.icon returned by the Bridge API status endpoint could be null, which caused validation to fail. It updates the types and the validation to match what the Bridge API returns.

Related issues

Related to #28899

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review December 10, 2024 19:57
@metamaskbot
Copy link
Collaborator

Builds ready [69efdb6]
Page Load Metrics (1999 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16262293200617986
domContentLoaded15872275197317483
load16242290199917383
domInteractive266738115
backgroundConnect879272110
firstReactRender16302032
getState1123871566833
initialActions01000
loadScripts11861794153415374
setupStore779162110
uiStartup185330942361268129
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 17 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

micaelae
micaelae previously approved these changes Dec 10, 2024
jclancy93
jclancy93 previously approved these changes Dec 10, 2024
ejwessel
ejwessel previously approved these changes Dec 10, 2024
Copy link

@MainS2020 MainS2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@metamaskbot
Copy link
Collaborator

Builds ready [46e7e8d]
Page Load Metrics (2092 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18762592208817383
domContentLoaded18312577206018086
load18762595209217986
domInteractive276840126
backgroundConnect1081312311
firstReactRender16352252
getState102179136199
initialActions01000
loadScripts14291984163214168
setupStore713921
uiStartup211030092414222107
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 17 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@infiniteflower infiniteflower force-pushed the mb1803-xchain-status-validator-token-null branch from 46e7e8d to 376e210 Compare December 11, 2024 18:14
@metamaskbot
Copy link
Collaborator

Builds ready [376e210]
Page Load Metrics (1726 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15012075172913364
domContentLoaded14842003169612761
load15032026172613364
domInteractive267034115
backgroundConnect1067302010
firstReactRender1780362411
getState55920189
initialActions01000
loadScripts10761563127811254
setupStore65916178
uiStartup17112445195016479
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 17 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@infiniteflower infiniteflower added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 3d9db73 Dec 11, 2024
77 checks passed
@infiniteflower infiniteflower deleted the mb1803-xchain-status-validator-token-null branch December 11, 2024 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants