-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: token.icon possibly null, update validators and types #29065
Merged
infiniteflower
merged 3 commits into
main
from
mb1803-xchain-status-validator-token-null
Dec 11, 2024
Merged
fix: token.icon possibly null, update validators and types #29065
infiniteflower
merged 3 commits into
main
from
mb1803-xchain-status-validator-token-null
Dec 11, 2024
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [69efdb6]
Page Load Metrics (1999 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
previously approved these changes
Dec 10, 2024
jclancy93
reviewed
Dec 10, 2024
jclancy93
previously approved these changes
Dec 10, 2024
ejwessel
previously approved these changes
Dec 10, 2024
infiniteflower
dismissed stale reviews from ejwessel, jclancy93, and micaelae
via
December 11, 2024 15:13
46e7e8d
MainS2020
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Builds ready [46e7e8d]
Page Load Metrics (2092 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
approved these changes
Dec 11, 2024
jclancy93
approved these changes
Dec 11, 2024
infiniteflower
force-pushed
the
mb1803-xchain-status-validator-token-null
branch
from
December 11, 2024 18:14
46e7e8d
to
376e210
Compare
Builds ready [376e210]
Page Load Metrics (1726 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.10.1
Issue or pull request that will be included in release 12.10.1
label
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
token.icon
returned by the Bridge API status endpoint could benull
, which caused validation to fail. It updates the types and the validation to match what the Bridge API returns.Related issues
Related to #28899
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist