fix: solana balance on accounts selector #29054

aganglada · 2024-12-10T14:54:40Z

Description

Solana native balance weren't showing before

Related issues

Fixes:

Manual testing steps

As of right now, manually testing is a bit complex, it needs to run the snap manually and the extension, since we 1st need to publish a new release to npm with more up to date work. The snap version we have in npm is outdated and won't support this flow. That said, if you want to go ahead and run locally the steps are the following:

Clone the Solana Snap monorepo and run it locally with yarn and then yarn start
In the extension, at this branch, apply the following changes and run the extension as flask:

At builds.yml add the solana feature to the flask build:
 
     features:
       - build-flask
       - keyring-snaps
+      - solana

At shared/lib/accounts/solana-wallet-snap.ts point the snap ID to the snap localhost:

-export const SOLANA_WALLET_SNAP_ID: SnapId = SolanaWalletSnap.snapId as SnapId;
+//export const SOLANA_WALLET_SNAP_ID: SnapId = SolanaWalletSnap.snapId as SnapId;
+export const SOLANA_WALLET_SNAP_ID: SnapId = "local:http://localhost:8080/";

Manually install the snap via the snap dapp at http://localhost:3000
Enable the Solana account via Settings > Experimental > Enable Solana account
Create a Solana account from the account-list menu and see the account balance on it

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-10T14:54:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-12-10T14:56:31Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	`0`	639 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security · 2024-12-10T14:56:33Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/@metamask/[email protected]	Module: globalThis["fetch"] Location: Package overview	`package.json` `yarn.lock`	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/@metamask/[email protected]

javiergarciavera

Great!

metamaskbot · 2024-12-10T15:28:52Z

Builds ready [47143db]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2071 ± 127 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	346	2843	1880	545	262
		domContentLoaded	1699	2811	2048	259	124
		load	1711	2841	2071	265	127
		domInteractive	25	73	38	13	6
		backgroundConnect	7	84	19	18	9
		firstReactRender	17	98	24	17	8
		getState	87	369	148	54	26
		initialActions	0	0	0	0	0
		loadScripts	1261	2358	1584	260	125
		setupStore	7	75	13	14	7
		uiStartup	2006	3137	2390	275	132

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-10T18:25:51Z

Builds ready [a9bdc68]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1851 ± 67 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1634	2221	1849	140	67
		domContentLoaded	1628	2156	1829	133	64
		load	1640	2214	1851	139	67
		domInteractive	23	49	31	7	3
		backgroundConnect	9	57	24	16	8
		firstReactRender	15	90	29	25	12
		getState	79	298	148	63	30
		initialActions	0	1	0	0	0
		loadScripts	1206	1666	1403	120	58
		setupStore	7	14	8	2	1
		uiStartup	1852	2845	2199	245	118

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1 Bytes (0.00%)
common: 0 Bytes (0.00%)

ccharly

Was able to test:

Before

After

metamaskbot · 2024-12-11T20:05:48Z

Builds ready [a1a563d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1565 ± 33 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1468	1743	1567	69	33
		domContentLoaded	1460	1730	1540	66	32
		load	1469	1742	1565	68	33
		domInteractive	24	66	39	15	7
		backgroundConnect	9	89	26	21	10
		firstReactRender	15	99	45	33	16
		getState	4	51	13	14	7
		initialActions	0	1	0	0	0
		loadScripts	1088	1261	1161	45	22
		setupStore	6	51	11	13	6
		uiStartup	1626	2077	1818	150	72

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-11T22:06:09Z

Builds ready [c4dd6ec]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1625 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1468	1844	1631	97	46
		domContentLoaded	1428	1760	1605	91	44
		load	1471	1784	1625	89	43
		domInteractive	23	66	39	16	7
		backgroundConnect	8	59	23	16	8
		firstReactRender	17	98	47	26	13
		getState	5	64	12	16	8
		initialActions	0	0	0	0	0
		loadScripts	1009	1335	1183	88	42
		setupStore	6	53	10	10	5
		uiStartup	1642	2203	1836	123	59

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 1 Bytes (0.00%)
common: 0 Bytes (0.00%)

aganglada self-assigned this Dec 10, 2024

aganglada requested a review from a team as a code owner December 10, 2024 14:54

metamaskbot added the team-sol PRs from the Solana snap team label Dec 10, 2024

javiergarciavera previously approved these changes Dec 10, 2024

View reviewed changes

zone-live previously approved these changes Dec 10, 2024

View reviewed changes

aganglada dismissed stale reviews from zone-live and javiergarciavera via a9bdc68 December 10, 2024 17:54

zone-live previously approved these changes Dec 11, 2024

View reviewed changes

ccharly previously approved these changes Dec 11, 2024

View reviewed changes

aganglada enabled auto-merge December 11, 2024 16:34

aganglada disabled auto-merge December 11, 2024 19:29

aganglada dismissed stale reviews from ccharly and zone-live via a1a563d December 11, 2024 19:31

aganglada force-pushed the fix/account-balance-solana branch from a9bdc68 to a1a563d Compare December 11, 2024 19:31

aganglada added 2 commits December 11, 2024 22:31

fix: solana balance on accounts selector

df7e25c

chore: fix tests

c4dd6ec

aganglada force-pushed the fix/account-balance-solana branch from a1a563d to c4dd6ec Compare December 11, 2024 21:34

darkwing approved these changes Dec 11, 2024

View reviewed changes

zone-live approved these changes Dec 12, 2024

View reviewed changes

aganglada added this pull request to the merge queue Dec 12, 2024

Merged via the queue into main with commit 714fa10 Dec 12, 2024
76 of 77 checks passed

aganglada deleted the fix/account-balance-solana branch December 12, 2024 11:26

github-actions bot locked and limited conversation to collaborators Dec 12, 2024

metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: solana balance on accounts selector #29054

fix: solana balance on accounts selector #29054

aganglada commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024

socket-security bot commented Dec 10, 2024 •

edited

Loading

socket-security bot commented Dec 10, 2024 •

edited

Loading

javiergarciavera left a comment

metamaskbot commented Dec 10, 2024

metamaskbot commented Dec 10, 2024

ccharly left a comment

metamaskbot commented Dec 11, 2024

metamaskbot commented Dec 11, 2024

fix: solana balance on accounts selector #29054

fix: solana balance on accounts selector #29054

Conversation

aganglada commented Dec 10, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 10, 2024

socket-security bot commented Dec 10, 2024 • edited Loading

socket-security bot commented Dec 10, 2024 • edited Loading

Next steps

javiergarciavera left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 10, 2024

metamaskbot commented Dec 10, 2024

ccharly left a comment

Choose a reason for hiding this comment

Before

After

metamaskbot commented Dec 11, 2024

metamaskbot commented Dec 11, 2024

aganglada commented Dec 10, 2024 •

edited

Loading

socket-security bot commented Dec 10, 2024 •

edited

Loading

socket-security bot commented Dec 10, 2024 •

edited

Loading