Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CODEOWNERS for bridge related code #29029

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 9, 2024

Description

Open in GitHub Codespaces

This PR updates CODEOWNERS for all Bridge related code.

Related issues

n/a

Manual testing steps

n/a

Screenshots/Recordings

n/a

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review December 9, 2024 18:09
@infiniteflower infiniteflower requested a review from a team as a code owner December 9, 2024 18:09
@metamaskbot
Copy link
Collaborator

Builds ready [4f2bbcd]
Page Load Metrics (1911 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26222801829390187
domContentLoaded16692266189015474
load17262282191115273
domInteractive278441199
backgroundConnect65925157
firstReactRender158422157
getState843121344421
initialActions00000
loadScripts12641815146114770
setupStore712921
uiStartup19412654219820297
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

.github/CODEOWNERS Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [7aca15d]
Page Load Metrics (1708 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15572065170812158
domContentLoaded15502039169211756
load15572045170811455
domInteractive23422863
backgroundConnect85216115
firstReactRender1490242211
getState803771386732
initialActions01000
loadScripts11821655130811153
setupStore610711
uiStartup17602594198619895
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

ui/pages/swaps @MetaMask/swaps-engineers
app/scripts/controllers/swaps @MetaMask/swaps-engineers

# Swaps-Bridge team to own code for the bridge folder
**/bridge/** @MetaMask/swaps-engineers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have types, like bridge-status.ts that lives outside of this structure. For files like these, should we:

  • colocate them in this or a follow on PR?
  • Add specific entries for those files here?

Not blocking, just wanted to call out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make a new PR to add additional files

Copy link
Contributor

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@desi desi added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@infiniteflower infiniteflower added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 1814c2b Dec 11, 2024
75 checks passed
@infiniteflower infiniteflower deleted the mb1586-xchain-bridge-codeowners branch December 11, 2024 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-bridge team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants