-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update CODEOWNERS for bridge related code #29029
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [4f2bbcd]
Page Load Metrics (1911 ± 73 ms)
Bundle size diffs
|
Builds ready [7aca15d]
Page Load Metrics (1708 ± 55 ms)
Bundle size diffs
|
ui/pages/swaps @MetaMask/swaps-engineers | ||
app/scripts/controllers/swaps @MetaMask/swaps-engineers | ||
|
||
# Swaps-Bridge team to own code for the bridge folder | ||
**/bridge/** @MetaMask/swaps-engineers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have types, like bridge-status.ts that lives outside of this structure. For files like these, should we:
- colocate them in this or a follow on PR?
- Add specific entries for those files here?
Not blocking, just wanted to call out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make a new PR to add additional files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR updates
CODEOWNERS
for all Bridge related code.Related issues
n/a
Manual testing steps
n/a
Screenshots/Recordings
n/a
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist