Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Snaps state methods #29016

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Dec 9, 2024

Description

This adds support for new methods to manage state from Snaps:

  • snap_getState
  • snap_setState
  • snap_clearState

These will eventually replace the snap_manageState method we have currently.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Dec 9, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3646fe2]
Page Load Metrics (2196 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25729192035583280
domContentLoaded170028212159245118
load170928682196247119
domInteractive249345209
backgroundConnect1095402512
firstReactRender1694312110
getState1183051575125
initialActions01000
loadScripts12582155165620397
setupStore716921
uiStartup217032842574278134
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 322 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 50 Bytes (0.00%)

@Mrtenz Mrtenz force-pushed the mrtenz/state-methods branch from 3646fe2 to adfc3dd Compare December 20, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants