Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update NFT approve page title #29010

Closed
wants to merge 2 commits into from

Conversation

prateekpur
Copy link

Description

Change NFT Approve title from Allowance Request to Withdrawal Request.

Related issues

Fixes: NA

Manual testing steps

  1. Open NFT allowance confirmation
  2. Ensure that title is Withdrawal Request

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 8, 2024

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 2 committers have signed the CLA.
@prateek Puri
@prateekpur

GitHub can't find an account for Prateek Puri, prateekpur.
You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@prateekpur
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 9, 2024
@prateekpur prateekpur force-pushed the nft_approve_fix branch 2 times, most recently from 72e17ab to efcd98c Compare December 9, 2024 10:51
@jpuri jpuri closed this Dec 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants