fix: Fix create metric fragment

[Gudahtt]

Description

The function createEventFragment of the MetaMetricsController was broken recently in the migration to BaseControllerV2 (#28113). We ended up trying to mutate a piece of Immer state, resulting in an error.

The affected line was updated to use cloneDeep prior to mutating, so that we're no longer attempting to mutate a frozen object.

Related issues

Fixes #28599

Manual testing steps

I'm not sure exactly how to reproduce the error using a real build. But the problem is easy to demonstrate in the "should update existing fragment state with new fragment props" unit test. The problem is that we didn't catch this before because Lodash doesn't have strict mode enabled, so in unit tests the attempt to mutate a frozen object will silently fail. In a production build, strict mode is enabled by LavaMoat.

You can reproduce the problem by adding "use strict" to the top of the file node_modules/lodash/lodash.js and running the test with the {}, removed. Then you can test that adding back {} as the initial parameter fixes the problem.

Screenshots/Recordings

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [4f47a46]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2036 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	393	2466	1953	398	191
		domContentLoaded	1669	2444	2000	164	79
		load	1726	2472	2036	166	80
		domInteractive	27	89	42	18	9
		backgroundConnect	7	85	37	25	12
		firstReactRender	15	83	25	15	7
		getState	91	308	147	52	25
		initialActions	0	1	0	0	0
		loadScripts	1228	1855	1537	146	70
		setupStore	7	18	9	3	1
		uiStartup	1952	3061	2359	244	117

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 17 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [612e9c5]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2060 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	265	2437	1798	662	318
		domContentLoaded	1602	2391	2036	233	112
		load	1643	2440	2060	235	113
		domInteractive	26	109	50	21	10
		backgroundConnect	7	63	24	18	9
		firstReactRender	15	94	28	22	11
		getState	77	357	160	62	30
		initialActions	0	1	0	0	0
		loadScripts	1205	1859	1571	198	95
		setupStore	6	23	10	3	2
		uiStartup	1943	2947	2427	298	143

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 3 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[desi]

LGTM