Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Permission page tour removal #28966

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Dec 5, 2024

This PR is to remove product tour from Permissions Page

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3755

Manual testing steps

  1. Run extension with yarn start
  2. Install a fresh version
  3. Go to Permissions Page, check there is no Product Tour

Screenshots/Recordings

Before

Screenshot 2024-12-05 at 3 53 47 PM

After

Screenshot 2024-12-05 at 3 54 50 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested review from a team as code owners December 5, 2024 15:54
@metamaskbot metamaskbot added team-wallet-ux INVALID-PR-TEMPLATE PR's body doesn't match template labels Dec 5, 2024
@NidhiKJha NidhiKJha added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Dec 5, 2024
@darkwing
Copy link
Contributor

darkwing commented Dec 5, 2024

Glad to see this going away!

@metamaskbot
Copy link
Collaborator

Builds ready [9cb1f10]
Page Load Metrics (2103 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17892361209914268
domContentLoaded17722342207114268
load18332369210314067
domInteractive269536157
backgroundConnect96626178
firstReactRender179325168
getState814081446330
initialActions01000
loadScripts13671831162112158
setupStore7241042
uiStartup206631382444222106
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -832 Bytes (-0.01%)
  • common: -214 Bytes (-0.00%)

@DDDDDanica
Copy link
Contributor

LGTM!

@NidhiKJha NidhiKJha added this pull request to the merge queue Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
This PR is to remove product tour from Permissions Page

## **Related issues**

Fixes:
[https://github.com/MetaMask/MetaMask-planning/issues/3755](https://github.com/MetaMask/MetaMask-planning/issues/3755)

## **Manual testing steps**

1. Run extension with `yarn start`
2. Install a fresh version
3. Go to Permissions Page, check there is no Product Tour

## **Screenshots/Recordings**


### **Before**
![Screenshot 2024-12-05 at 3 53
47 PM](https://github.com/user-attachments/assets/a020cd59-492c-43df-af41-0f7a5ec7f142)



### **After**

![Screenshot 2024-12-05 at 3 54
50 PM](https://github.com/user-attachments/assets/e77251f3-c3c9-433b-bef8-218dceba2bf5)

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 5c1c4b2 Dec 12, 2024
75 checks passed
@NidhiKJha NidhiKJha deleted the permission-page-tour-removal branch December 12, 2024 14:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.10.1 Issue or pull request that will be included in release 12.10.1 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants