chore: Update CODEOWNERS to remove ownership from most #28941

Gudahtt · 2024-12-04T20:23:47Z

Description

The CODEOWNERS file has been updated to remove ownership from most files, to give us more time to plan which files the platform should own, and to give teams more time to consolidate their features.

Also, ownership of the CODEOWNERS file itself was moved to the extension security team (it was accidentally set to privacy reviewers).

Related issues

This is an adjustment to recent changes made in #28851

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

.github/CODEOWNERS

desi · 2024-12-05T00:14:49Z

.github/CODEOWNERS

@@ -45,7 +64,7 @@ privacy-snapshot.json                @MetaMask/extension-privacy-reviewers
 # of contributors. Modifications to this file result in a modification of
 # that agreement and can only be approved by those with the knowledge
 # and responsibility to publish libraries under the MetaMask name.
-.github/CODEOWNERS                   @MetaMask/extension-privacy-reviewers
+.github/CODEOWNERS                   @MetaMask/extension-security-team


Thank you for catching this. I was just coming here to ask if you'd fix it. :)

metamaskbot · 2024-12-05T00:30:49Z

Builds ready [388a835]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2286 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	453	2694	2093	555	266
		domContentLoaded	1922	2682	2239	181	87
		load	1936	2735	2286	178	85
		domInteractive	28	158	53	27	13
		backgroundConnect	10	110	45	27	13
		firstReactRender	16	175	38	39	19
		getState	100	402	164	71	34
		initialActions	0	0	0	0	0
		loadScripts	1475	2192	1752	177	85
		setupStore	8	80	14	15	7
		uiStartup	2247	3644	2706	345	165

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

The CODEOWNERS file has been updated to remove owners from key files that are frequently updated by multiple teams. Certain files that are validated as part of the release process have also been unset, as there are no risks with teams updating them in PRs. Lastly, ownership of the CODEOWNERS file itself was moved to the extension security team (it was accidentally set to privacy reviewers).

metamaskbot · 2024-12-05T13:35:46Z

Builds ready [5505964]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1935 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	533	2236	1861	348	167
		domContentLoaded	1623	2180	1900	166	80
		load	1677	2240	1935	166	80
		domInteractive	25	84	38	14	7
		backgroundConnect	9	89	42	24	12
		firstReactRender	15	32	20	4	2
		getState	78	303	131	44	21
		initialActions	0	1	0	0	0
		loadScripts	1206	1714	1461	134	64
		setupStore	6	75	12	15	7
		uiStartup	1917	2640	2237	212	102

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

We will revisit the idea of the platform team owning more code in a future PR.

metamaskbot · 2024-12-05T15:33:55Z

Builds ready [44bb5b2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1875 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1653	2275	1866	161	78
		domContentLoaded	1636	2184	1836	148	71
		load	1657	2324	1875	171	82
		domInteractive	25	69	32	11	5
		backgroundConnect	9	108	35	28	14
		firstReactRender	15	87	23	15	7
		getState	83	268	133	37	18
		initialActions	0	1	0	0	0
		loadScripts	1211	1713	1401	130	63
		setupStore	7	18	9	3	1
		uiStartup	1905	3225	2221	320	154

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt added the team-extension-platform label Dec 4, 2024

metamaskbot added the team-wallet-framework label Dec 4, 2024

Gudahtt force-pushed the update-codeowners branch 2 times, most recently from 0e8740e to 737945d Compare December 4, 2024 20:28

Gudahtt marked this pull request as ready for review December 4, 2024 21:25

Gudahtt requested a review from a team as a code owner December 4, 2024 21:25

Gudahtt force-pushed the update-codeowners branch from 737945d to f467403 Compare December 4, 2024 21:26

Gudahtt commented Dec 4, 2024

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Gudahtt commented Dec 4, 2024

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Gudahtt force-pushed the update-codeowners branch from 6f79d62 to 388a835 Compare December 4, 2024 23:58

desi previously approved these changes Dec 5, 2024

View reviewed changes

Gudahtt dismissed desi’s stale review via 845fbd2 December 5, 2024 13:01

Gudahtt added 4 commits December 5, 2024 09:32

Improve comment about LavaMoat policy review

fdb7941

Slightly improve wording

948d7b1

Remove owners from locales, and metamask-controller tests

0275f5d

Gudahtt force-pushed the update-codeowners branch from 845fbd2 to 0275f5d Compare December 5, 2024 13:02

Temporarily restore extension-devs team for LavaMoat policies

5505964

Remove owners from * files

44bb5b2

We will revisit the idea of the platform team owning more code in a future PR.

Gudahtt changed the title ~~chore: Update CODEOWNERS to remove owner from some files~~ chore: Update CODEOWNERS to remove ownership from most Dec 5, 2024

FrederikBolding approved these changes Dec 5, 2024

View reviewed changes

desi approved these changes Dec 5, 2024

View reviewed changes

Gudahtt enabled auto-merge December 5, 2024 15:52

danjm approved these changes Dec 5, 2024

View reviewed changes

Gudahtt added this pull request to the merge queue Dec 5, 2024

cryptotavares approved these changes Dec 5, 2024

View reviewed changes

Merged via the queue into main with commit 47c89ec Dec 5, 2024
81 checks passed

Gudahtt deleted the update-codeowners branch December 5, 2024 16:15

github-actions bot locked and limited conversation to collaborators Dec 5, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update CODEOWNERS to remove ownership from most #28941

chore: Update CODEOWNERS to remove ownership from most #28941

Gudahtt commented Dec 4, 2024 •

edited

Loading

desi Dec 5, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

chore: Update CODEOWNERS to remove ownership from most #28941

chore: Update CODEOWNERS to remove ownership from most #28941

Conversation

Gudahtt commented Dec 4, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

desi Dec 5, 2024

Choose a reason for hiding this comment

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

Gudahtt commented Dec 4, 2024 •

edited

Loading