Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky ppom test #28923

Merged
merged 2 commits into from
Dec 5, 2024
Merged

test: fix flaky ppom test #28923

merged 2 commits into from
Dec 5, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Dec 4, 2024

Description

Sometimes it takes a little longer for the spinner to go away and for the blockaid banner to show up. Just increasing the dynamic timeout waiting for the spinner to be removed from the page so that in the situations where it takes a little longer the tests don't fail.

Open in GitHub Codespaces

Related issues

Fixes: #28872

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner December 4, 2024 12:56
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [7a2323d]
Page Load Metrics (1812 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15432194181116780
domContentLoaded15302092177014369
load15532196181216680
domInteractive23243536230
backgroundConnect8175444019
firstReactRender15281942
getState883911417235
initialActions01000
loadScripts11291699135213565
setupStore7281063
uiStartup180929202118244117
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham added this pull request to the merge queue Dec 5, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8842bce]
Page Load Metrics (1973 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34122391897374179
domContentLoaded17322215193611153
load17462312197312058
domInteractive257036126
backgroundConnect1276352010
firstReactRender169024167
getState972771363919
initialActions00000
loadScripts13271772150510450
setupStore77712157
uiStartup19682834231219694
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit a894ba5 Dec 5, 2024
75 checks passed
@HowardBraham HowardBraham deleted the ppom-flaky-test branch December 5, 2024 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "PPOM Blockaid Alert - Set Trade farming order @no-mm..." flaky tests
4 participants