Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/account-watcher to ^4.2.2 #28915

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Dec 4, 2024

Description

This new version now uses devDependencies rather than dependencies, which avoid pulling unnecessary deps into the main tree (check the yarn.lock).

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly requested a review from a team as a code owner December 4, 2024 09:04
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 992 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Copy link
Contributor

@montelaidev montelaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@metamaskbot
Copy link
Collaborator

Builds ready [5c3c2c2]
Page Load Metrics (1737 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint144023991736258124
domContentLoaded143323331706235113
load144124701737265127
domInteractive239637199
backgroundConnect7259365426
firstReactRender14331742
getState984281396832
initialActions00000
loadScripts103118411290215103
setupStore67113147
uiStartup166632231996368177
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ccharly ccharly added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@gantunesr gantunesr added this pull request to the merge queue Dec 4, 2024
@Gudahtt Gudahtt removed this pull request from the merge queue due to a manual request Dec 4, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Dec 4, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Dec 4, 2024

Removed and re-added to queue to let the audit fix get in first

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@ccharly ccharly added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 27f3c21 Dec 5, 2024
81 checks passed
@ccharly ccharly deleted the chore/update-snap-watch-only branch December 5, 2024 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-accounts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants