Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert NFT views to TS, upgrade deprecated patterns #28906

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Dec 4, 2024

Description

This PR updates some of the existing nft views with some updated patterns to bring it up to date with existing Assets components. Changes included:

  1. Updating several relevant files to TypeScript
  2. Upgrading deprecated components like Menu to updated components like Popover and SelectableListItem.
  3. Updating styles to align more closely with design system (h5 titles are no deprecated)

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

NFT experience should not regress in any way. Visually there may be some slight differences.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title Feat/nft grid view v1 feat: NftGridView Dec 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [e85c187]
Page Load Metrics (2009 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46626221864468225
domContentLoaded16372536198219493
load16932562200919895
domInteractive266638126
backgroundConnect889282110
firstReactRender16432273
getState1131981402110
initialActions01000
loadScripts12431886151414871
setupStore77612157
uiStartup199728802349209100
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -3.88 KiB (-0.05%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish marked this pull request as ready for review December 14, 2024 01:15
@gambinish gambinish requested review from a team as code owners December 14, 2024 01:15
@metamaskbot
Copy link
Collaborator

Builds ready [9f25019]
Page Load Metrics (1878 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29420771806358172
domContentLoaded1690206418569445
load1746207618788541
domInteractive23543284
backgroundConnect86822136
firstReactRender158121147
getState1082241352813
initialActions00000
loadScripts1282166514459043
setupStore77311147
uiStartup19642581218614871
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -3.83 KiB (-0.05%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish changed the title feat: NftGridView chore: Convert NFT views to ts, upgrade deprecated patterns Dec 19, 2024
@gambinish gambinish changed the title chore: Convert NFT views to ts, upgrade deprecated patterns chore: Convert NFT views to TS, upgrade deprecated patterns Dec 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f983745]
Page Load Metrics (1697 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14592030169616278
domContentLoaded14521981167215373
load14701988169714971
domInteractive26148513014
backgroundConnect9104202110
firstReactRender1692432713
getState569232311
initialActions01000
loadScripts10141426122712258
setupStore75615178
uiStartup169924881961207100

@metamaskbot
Copy link
Collaborator

Builds ready [393e995]
Page Load Metrics (1615 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1472179016168039
domContentLoaded1450177515998541
load1474178816158239
domInteractive24186483617
backgroundConnect75923157
firstReactRender1694493014
getState589222412
initialActions01000
loadScripts1047135611998039
setupStore69710
uiStartup16702285190019493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants