Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated analytics preferences to be logged during onboarding #28897

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

NidhiKJha
Copy link
Member

During onboarding while clicking on I agree button, the analytics preferences event was not being triggered. This PR is to ensure analytics preferences are logged when user click on I agree button in Onboarding Page

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3723

Manual testing steps

  1. Run extension with yarn start
  2. Add console.log in trackEvent in ui/contexts/metametrics.js to see the payload
  3. Do a fresh install and go on onboading flow
  4. Click on I agree button on onboarding screen, check analytics preferences selected are being logged in console

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-03.at.5.54.36.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner December 3, 2024 19:58
@metamaskbot metamaskbot added team-wallet-ux INVALID-PR-TEMPLATE PR's body doesn't match template labels Dec 3, 2024
@NidhiKJha NidhiKJha changed the title fix:updated analytics preferences to be logged during onboarding fix: updated analytics preferences to be logged during onboarding Dec 3, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1b2fb47]
Page Load Metrics (2062 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint164226492062240115
domContentLoaded163625542026222106
load164025582062230111
domInteractive25236484622
backgroundConnect7123393517
firstReactRender15195334119
getState974871638240
initialActions01000
loadScripts12312008154418890
setupStore7331263
uiStartup189431882427326157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -56 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit f8ae136 Dec 4, 2024
84 of 86 checks passed
@NidhiKJha NidhiKJha deleted the fix-3723 branch December 4, 2024 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants