feat: migrate Base network RPC from https://mainnet.base.org to base-…

[salimtb]

Description

This PR introduces a migration to replace the Base network RPC URL (https://mainnet.base.org) with the new Infura RPC URL (https://base-mainnet.infura.io/v3/{infuraProjectId}) in the MetaMask state.

Related issues

Fixes:

Manual testing steps

1. build the app on main branch and put the file on tmp-chrome folder
2. Add base network
3. build the app on the current branch
4. replace the main build with the new one
5. base url should be updated

Screenshots/Recordings

Before

After

migration.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [d001d7c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1763 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	270	2139	1694	348	167
		domContentLoaded	1608	2127	1738	122	59
		load	1619	2194	1763	130	62
		domInteractive	25	99	39	19	9
		backgroundConnect	9	67	29	18	9
		firstReactRender	15	86	21	15	7
		getState	68	185	113	28	13
		initialActions	0	1	0	0	0
		loadScripts	1221	1713	1349	113	54
		setupStore	6	11	7	1	1
		uiStartup	1848	2441	2042	166	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.77 KiB (0.03%)
• ui: 1.02 KiB (0.01%)
• common: 229 Bytes (0.00%)

[metamaskbot]

Builds ready [51abcd1]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1863 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	278	2106	1773	360	173
		domContentLoaded	1639	2084	1843	116	56
		load	1706	2107	1863	114	55
		domInteractive	26	102	37	16	8
		backgroundConnect	8	43	20	10	5
		firstReactRender	15	31	19	4	2
		getState	77	174	131	18	9
		initialActions	0	72	4	16	8
		loadScripts	1234	1636	1389	114	55
		setupStore	7	31	10	6	3
		uiStartup	1914	2468	2184	165	79

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.77 KiB (0.03%)
• ui: 1.02 KiB (0.01%)
• common: 229 Bytes (0.00%)

[metamaskbot]

Builds ready [cde651e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2202 ± 411 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	274	4179	1831	991	476
		domContentLoaded	1555	4156	2174	838	402
		load	1563	4200	2202	857	411
		domInteractive	25	266	60	60	29
		backgroundConnect	6	668	58	143	69
		firstReactRender	15	66	25	13	6
		getState	108	387	151	62	30
		initialActions	0	1	0	0	0
		loadScripts	1164	3432	1703	723	347
		setupStore	7	75	15	15	7
		uiStartup	1771	5427	2608	1077	517

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.8 KiB (0.03%)
• ui: 1.06 KiB (0.01%)
• common: 253 Bytes (0.00%)

[metamaskbot]

Builds ready [a936f0f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1857 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	320	2257	1793	360	173
		domContentLoaded	1640	2236	1829	128	62
		load	1659	2250	1857	129	62
		domInteractive	27	117	44	25	12
		backgroundConnect	10	53	24	16	8
		firstReactRender	15	88	22	15	7
		getState	78	198	127	22	11
		initialActions	0	1	0	0	0
		loadScripts	1255	1823	1428	121	58
		setupStore	7	10	8	1	0
		uiStartup	1885	2558	2141	173	83

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.8 KiB (0.03%)
• ui: 1.21 KiB (0.02%)
• common: 253 Bytes (0.00%)

[danjm]

LGTM

[darkwing]

Upon starting extension locally, I see the following:

Error: BaseNetworkToast(...): Nothing was returned from render. This usually means a return statement is missing. Or, to render nothing, return null. '\n  at BaseNetworkToast (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-5.js:11818:48)\n  at div\n  at chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-10.js:18991:3\n  at ToastContainer (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-7.js:3811:3)\n  at ToastMaster (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-5.js:11689:52)\n  at div\n  at Routes (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-11.js:10280:1)\n  at ConnectFunction (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-9.js:31876:41)\n  at C (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:16054:37)\n  at MetamaskNotificationsProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-8.js:35:3)\n  at AssetPollingProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-7.js:15366:3)\n  at LegacyI18nProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-10.js:24087:1)\n  at I18nProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-10.js:24070:53)\n  at LegacyMetaMetricsProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-8.js:222:1)\n  at MetaMetricsProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-8.js:132:3)\n  at RenderedRoute (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:16767:7)\n  at Routes (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:17468:7)\n  at Router (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:17402:17)\n  at CompatRouter (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:13274:7)\n  at Router (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:15416:30)\n  at HashRouter (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:13755:35)\n  at Provider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-9.js:31583:20)\n  at Index (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-11.js:945:5)'

After refreshing the extension, it works:

I believe this is fine because upon updating the extension in prod, the extension restarts.

The migration also worked great.

[salimtb]

Upon starting extension locally, I see the following:

Error: BaseNetworkToast(...): Nothing was returned from render. This usually means a return statement is missing. Or, to render nothing, return null. '\n  at BaseNetworkToast (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-5.js:11818:48)\n  at div\n  at chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-10.js:18991:3\n  at ToastContainer (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-7.js:3811:3)\n  at ToastMaster (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-5.js:11689:52)\n  at div\n  at Routes (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-11.js:10280:1)\n  at ConnectFunction (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-9.js:31876:41)\n  at C (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:16054:37)\n  at MetamaskNotificationsProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-8.js:35:3)\n  at AssetPollingProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-7.js:15366:3)\n  at LegacyI18nProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-10.js:24087:1)\n  at I18nProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-10.js:24070:53)\n  at LegacyMetaMetricsProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-8.js:222:1)\n  at MetaMetricsProvider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-8.js:132:3)\n  at RenderedRoute (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:16767:7)\n  at Routes (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:17468:7)\n  at Router (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:17402:17)\n  at CompatRouter (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:13274:7)\n  at Router (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:15416:30)\n  at HashRouter (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-3.js:13755:35)\n  at Provider (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/common-9.js:31583:20)\n  at Index (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-11.js:945:5)'

After refreshing the extension, it works: I believe this is fine because upon updating the extension in prod, the extension restarts.

The migration also worked great.

I believe I understand why you encountered the strange local error. It's likely due to the use of the showBaseNetworkToast && ... expression, which doesn't always guarantee a return value. To improve the code's clarity and ensure consistent returns, I’ve switched to using a ternary expression instead.
83fe992