feat: bump @metamask/message-signing-snap to ^0.6.0 #28877

Prithpal-Sooriya · 2024-12-03T16:35:06Z

Description

Bumps message signing snap to ^0.6.0

Related issues

Fixes:

Manual testing steps

Ensure application still works as intended

Complete onboarding
Try to enable notifications (as this uses the snap)

Try using the preinstalled snap on sites. See snap docs for testing - can be tested in the browser.

Get eip6963 provider
Call connect
Call get public key
Call sign message

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-03T16:35:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…at/bump-message-signing-snap

socket-security · 2024-12-03T16:40:37Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	247 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected]

View full report↗︎

metamaskbot · 2024-12-03T17:34:37Z

Builds ready [c595a71]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2194 ± 129 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1757	2778	2208	286	137
		domContentLoaded	1716	2678	2167	273	131
		load	1757	2684	2194	268	129
		domInteractive	25	89	45	16	8
		backgroundConnect	10	79	34	20	9
		firstReactRender	15	91	27	16	7
		getState	120	407	180	79	38
		initialActions	0	1	0	0	0
		loadScripts	1280	2108	1657	233	112
		setupStore	7	12	9	2	1
		uiStartup	1975	3279	2594	359	172

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.52 KiB (0.10%)
ui: 0 Bytes (0.00%)
common: 126 Bytes (0.00%)

Prithpal-Sooriya · 2024-12-04T13:47:25Z

lavamoat/browserify/beta/policy.json

        "@ethereumjs/tx>ethereum-cryptography>@noble/hashes": true,
-        "@ethereumjs/tx>ethereum-cryptography>@scure/bip32": true,
-        "@metamask/message-signing-snap>@noble/curves": true


See snap changelog for dependency changes, hence lavamoat policy update.

metamaskbot · 2024-12-04T13:57:17Z

Builds ready [253ab1a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2085 ± 167 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	464	2688	1934	599	288
		domContentLoaded	1531	2666	2056	345	166
		load	1544	2694	2085	348	167
		domInteractive	24	72	47	16	8
		backgroundConnect	6	84	31	22	11
		firstReactRender	15	89	28	21	10
		getState	91	310	152	55	26
		initialActions	0	1	0	0	0
		loadScripts	1122	2119	1579	296	142
		setupStore	7	26	12	5	3
		uiStartup	1784	3089	2436	444	213

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.52 KiB (0.10%)
ui: 0 Bytes (0.00%)
common: 126 Bytes (0.00%)

…at/bump-message-signing-snap

metamaskbot · 2024-12-05T14:28:18Z

Builds ready [cd3cb72]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2002 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1754	2308	2010	166	80
		domContentLoaded	1744	2239	1971	151	73
		load	1756	2310	2002	157	75
		domInteractive	25	71	41	14	7
		backgroundConnect	10	91	33	27	13
		firstReactRender	16	104	29	24	12
		getState	89	303	139	46	22
		initialActions	0	0	0	0	0
		loadScripts	1323	1810	1535	131	63
		setupStore	7	75	12	15	7
		uiStartup	2029	3129	2341	277	133

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.52 KiB (0.11%)
ui: 0 Bytes (0.00%)
common: 126 Bytes (0.00%)

metamaskbot · 2024-12-06T10:22:10Z

Builds ready [9b66a01]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2009 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1763	2365	2008	153	73
		domContentLoaded	1755	2355	1985	149	72
		load	1794	2368	2009	149	72
		domInteractive	25	61	36	9	4
		backgroundConnect	7	72	23	19	9
		firstReactRender	16	94	29	22	11
		getState	125	272	147	32	15
		initialActions	0	1	0	0	0
		loadScripts	1325	1781	1519	114	55
		setupStore	7	91	13	18	9
		uiStartup	2023	2966	2375	268	129

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.52 KiB (0.11%)
ui: 0 Bytes (0.00%)
common: 126 Bytes (0.00%)

metamaskbot · 2024-12-06T12:33:32Z

Builds ready [b343157]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1972 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	269	2519	1887	427	205
		domContentLoaded	1695	2414	1938	192	92
		load	1713	2476	1972	205	98
		domInteractive	25	126	46	24	11
		backgroundConnect	7	74	34	22	10
		firstReactRender	16	93	24	17	8
		getState	88	286	135	43	21
		initialActions	0	1	0	0	0
		loadScripts	1251	1904	1482	173	83
		setupStore	6	77	12	15	7
		uiStartup	1963	2883	2296	264	127

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.52 KiB (0.11%)
ui: 0 Bytes (0.00%)
common: 126 Bytes (0.00%)

metamaskbot · 2024-12-09T11:44:32Z

Builds ready [52f041e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1934 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	344	2415	1775	501	240
		domContentLoaded	1719	2403	1913	174	84
		load	1738	2421	1934	176	85
		domInteractive	25	273	49	55	26
		backgroundConnect	7	66	21	18	9
		firstReactRender	15	26	19	3	2
		getState	101	196	134	20	10
		initialActions	0	1	0	0	0
		loadScripts	1312	1999	1506	166	80
		setupStore	7	14	9	2	1
		uiStartup	1966	2710	2210	203	98

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 5.52 KiB (0.11%)
ui: 0 Bytes (0.00%)
common: 126 Bytes (0.00%)

feat: bump @metamask/message-signing-snap to ^0.6.0

c25ddfc

Prithpal-Sooriya added team-notifications Notifications team team-identity labels Dec 3, 2024

Merge branch 'main' of github.com:MetaMask/metamask-extension into fe…

ec32d04

…at/bump-message-signing-snap

build: update lavamoat polices

c595a71

Prithpal-Sooriya marked this pull request as ready for review December 3, 2024 17:19

Prithpal-Sooriya requested review from a team as code owners December 3, 2024 17:19

Merge branch 'main' into feat/bump-message-signing-snap

cb60d37

mathieuartu previously approved these changes Dec 4, 2024

View reviewed changes

Merge branch 'main' into feat/bump-message-signing-snap

253ab1a

Prithpal-Sooriya commented Dec 4, 2024

View reviewed changes

Merge branch 'main' of github.com:MetaMask/metamask-extension into fe…

cd3cb72

…at/bump-message-signing-snap

Prithpal-Sooriya dismissed mathieuartu’s stale review via cd3cb72 December 5, 2024 13:56

FrederikBolding approved these changes Dec 5, 2024

View reviewed changes

Prithpal-Sooriya enabled auto-merge December 5, 2024 14:51

Merge branch 'main' into feat/bump-message-signing-snap

9b66a01

Prithpal-Sooriya requested a review from a team as a code owner December 6, 2024 09:44

Prithpal-Sooriya disabled auto-merge December 6, 2024 11:12

Prithpal-Sooriya removed the team-notifications Notifications team label Dec 6, 2024

Merge branch 'main' into feat/bump-message-signing-snap

b343157

Merge branch 'main' into feat/bump-message-signing-snap

52f041e

mathieuartu approved these changes Dec 9, 2024

View reviewed changes

Prithpal-Sooriya added this pull request to the merge queue Dec 9, 2024

Merged via the queue into main with commit 0eab55d Dec 9, 2024
75 checks passed

Prithpal-Sooriya deleted the feat/bump-message-signing-snap branch December 9, 2024 12:46

github-actions bot locked and limited conversation to collaborators Dec 9, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: bump @metamask/message-signing-snap to ^0.6.0 #28877

feat: bump @metamask/message-signing-snap to ^0.6.0 #28877

Prithpal-Sooriya commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024

socket-security bot commented Dec 3, 2024 •

edited

Loading

metamaskbot commented Dec 3, 2024

Prithpal-Sooriya Dec 4, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 6, 2024

metamaskbot commented Dec 6, 2024

metamaskbot commented Dec 9, 2024

feat: bump @metamask/message-signing-snap to ^0.6.0 #28877

feat: bump @metamask/message-signing-snap to ^0.6.0 #28877

Conversation

Prithpal-Sooriya commented Dec 3, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 3, 2024

socket-security bot commented Dec 3, 2024 • edited Loading

metamaskbot commented Dec 3, 2024

Prithpal-Sooriya Dec 4, 2024

Choose a reason for hiding this comment

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 6, 2024

metamaskbot commented Dec 6, 2024

metamaskbot commented Dec 9, 2024

Prithpal-Sooriya commented Dec 3, 2024 •

edited

Loading

socket-security bot commented Dec 3, 2024 •

edited

Loading