-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if a user is signed in before attempting to sign them out #28874
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this ensures that we check the auth state before performing sign out 👍🏾
We can create a separate PR that decouples UI interactions and instead uses the background messaging stateChanged
event - see gist
Builds ready [b0bfe1b]
Page Load Metrics (2448 ± 380 ms)
Bundle size diffs
|
Builds ready [86b39c9]
Page Load Metrics (2057 ± 69 ms)
Bundle size diffs
|
Description
This PR adds a
isUserSignedIn
check before attempting to sign him out.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3709
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist