-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support decimal point on advanced gas modal on mac #28869
Merged
Merged
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
force-pushed
the
pnf/28843
branch
from
December 5, 2024 11:35
2e872f6
to
59e8ccb
Compare
Builds ready [6ac6ef2]
Page Load Metrics (1706 ± 33 ms)
Bundle size diffs
|
pedronfigueiredo
force-pushed
the
pnf/28843
branch
3 times, most recently
from
December 6, 2024 10:59
cc6bafa
to
fca6491
Compare
pedronfigueiredo
force-pushed
the
pnf/28843
branch
from
December 6, 2024 11:14
fca6491
to
ddf4e7b
Compare
Builds ready [ddf4e7b]
Page Load Metrics (2021 ± 82 ms)
Bundle size diffs
|
jpuri
approved these changes
Dec 9, 2024
vinistevam
approved these changes
Dec 9, 2024
metamaskbot
added
the
release-12.10.0
Issue or pull request that will be included in release 12.10.0
label
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.10.0
Issue or pull request that will be included in release 12.10.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main bug this PR fixes only happens on mac, not linux. It is the following: when a user pressed
.
on the advanced gas modal and a number after it, a zero would appear instead the.
and any numbers before it. This is because in theonChange
inNumericInput
, when the user presses.
,e.target.value
is""
, and the code was defaulting the value that got passed to the on change handler to0
. To fix the bug, this PR removes that default, and necessarily theparseInt
that wrapped it.The PR also adds the
0
default to a few places where the newly possible""
value would otherwise break execution.This PR also prevents the user from setting decimal custom nonce values.
Finally, it prevents
,
to be registered whenallowDecimals
is set on<FormField />
, most notably for the gas limit input.Related issues
Fixes: #28843
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist