Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improvements to codeowners #28851

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

desi
Copy link
Contributor

@desi desi commented Dec 2, 2024

  • Extension Devs is no longer in use so removing
  • Sometime back the security team asked that we have a group who would be responsible for being mindful of security concerns as it relates to things like our CI pipeline. We needed a quick fix for that and so the library admins group was selected but it should really be a group that is best suited for that responsibility so we have created a new group reflecting that here and have added them as code owners for those areas.
  • Kumavis showing with the lock icon regularly was confusing for folks so we have removed them as a specific code owner

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

 - Extension Devs is no longer in use so removing
 - Sometime back the security team asked that we have a group who
   would be responsible for being mindful of security concerns as it
   relates to things like our CI pipeline. We needed a quick fix for
   that and so the library admins group was selected but it should
   really be a group that is best suited for that responsibility so
   we have created a new group reflecting that here and have added
   them as code owners for those areas.
 - Kumavis showing with the lock icon regularly was confusing for
   folks so we have removed them as a specific code owner
Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@desi desi changed the title (chore):Improvements to codeowners chore: Improvements to codeowners Dec 2, 2024
@desi desi marked this pull request as ready for review December 2, 2024 22:42
@desi desi requested review from kumavis and a team as code owners December 2, 2024 22:42
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [3872193]
Page Load Metrics (1790 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15032242179418991
domContentLoaded14952088175615474
load15042242179018087
domInteractive236837157
backgroundConnect8184303919
firstReactRender15241731
getState824781427938
initialActions00000
loadScripts11111636133614971
setupStore626952
uiStartup176428602053250120
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 7ab130c Dec 3, 2024
92 of 93 checks passed
@DDDDDanica DDDDDanica deleted the chore/dm-update-codeowners branch December 3, 2024 00:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants