Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show banner for delayed bridge tx #28849

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 2, 2024

Description

This PR adds a banner to tell users to reach out to Support if the Bridge tx is delayed.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Start a Bridge tx
  2. Wait a bit
  3. Banner should appear

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-02.at.3.54.13.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower force-pushed the mb1571-cross-chain-swap-stx branch from f33d3f0 to 86e1202 Compare December 2, 2024 23:14
@infiniteflower infiniteflower force-pushed the mb1743-cross-chain-swap-tx-failures branch from 06f69d0 to 42e8a46 Compare December 2, 2024 23:18
@metamaskbot
Copy link
Collaborator

Builds ready [42e8a46]
Page Load Metrics (1926 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26925691764537258
domContentLoaded163824831905241116
load168625011926241116
domInteractive23100392010
backgroundConnect893292412
firstReactRender159225178
getState753661445526
initialActions00000
loadScripts12361954147520599
setupStore6441184
uiStartup189329152243320153
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 521 Bytes (0.01%)
  • ui: 2.83 KiB (0.04%)
  • common: 441 Bytes (0.01%)

@infiniteflower infiniteflower marked this pull request as ready for review December 4, 2024 15:24
@infiniteflower infiniteflower requested a review from a team as a code owner December 4, 2024 15:24
Base automatically changed from mb1571-cross-chain-swap-stx to main December 5, 2024 16:50
@infiniteflower infiniteflower force-pushed the mb1743-cross-chain-swap-tx-failures branch from 42e8a46 to 7b16244 Compare December 5, 2024 17:52
@infiniteflower infiniteflower changed the title Mb1743 cross chain swap tx failures feat: show banner for delayed bridge tx Dec 5, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [7b16244]
Page Load Metrics (1721 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1630189217368340
domContentLoaded1552187216968340
load1564189017218641
domInteractive226330136
backgroundConnect76625209
firstReactRender159022168
getState803781226029
initialActions01000
loadScripts1168147113098239
setupStore612711
uiStartup17782504196715072
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.66 KiB (0.02%)
  • common: 202 Bytes (0.00%)

Copy link
Contributor

@ghgoodreau ghgoodreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@micaelae micaelae added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 9b4f20b Dec 9, 2024
78 checks passed
@micaelae micaelae deleted the mb1743-cross-chain-swap-tx-failures branch December 9, 2024 19:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants