-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup on some names and scripts in ci #28844
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2ba033c]
Page Load Metrics (2265 ± 87 ms)
|
@@ -491,7 +493,7 @@ jobs: | |||
at: . | |||
- run: | |||
name: Get changed files with git diff | |||
command: npx tsx .circleci/scripts/git-diff-develop.ts | |||
command: yarn git-diff-default-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better practice - and for that we need deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
After the default branch has been renamed from develop to main, there were some names that could improve on some ci scripts/files.
This Pr updates them
It also updates how the git diff was run, to use yarn as a better practice (pointed by Mark on another PR for the rerun-from-failed)
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist