Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup on some names and scripts in ci #28844

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Dec 2, 2024

Description

After the default branch has been renamed from develop to main, there were some names that could improve on some ci scripts/files.
This Pr updates them
It also updates how the git diff was run, to use yarn as a better practice (pointed by Mark on another PR for the rerun-from-failed)

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. All jobs should continue to work

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2ba033c]
Page Load Metrics (2265 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37826522064584281
domContentLoaded18692636224017785
load18862698226518287
domInteractive30105552110
backgroundConnect85619136
firstReactRender189534189
getState641941102211
initialActions01000
loadScripts13752098171616278
setupStore74713105
uiStartup22182917260816981

@seaona seaona marked this pull request as ready for review December 2, 2024 16:43
@seaona seaona requested review from kumavis and a team as code owners December 2, 2024 16:43
@seaona seaona changed the title chore: remaining cleanup chore: cleanup on some names and scripts in ci Dec 2, 2024
@seaona seaona self-assigned this Dec 2, 2024
@@ -491,7 +493,7 @@ jobs:
at: .
- run:
name: Get changed files with git diff
command: npx tsx .circleci/scripts/git-diff-develop.ts
command: yarn git-diff-default-branch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better practice - and for that we need deps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@itsyoboieltr itsyoboieltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DDDDDanica DDDDDanica added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@seaona seaona added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@seaona seaona added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 3ed6c75 Dec 3, 2024
102 checks passed
@seaona seaona deleted the cleanup-names-scripts branch December 3, 2024 08:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants