[cherry-pick] fix: Correct preferences controller usage for isOnPhishingList hook

[FrederikBolding]

Description

This is a cherry-pick to the RC for the following commit: db4386f

In this commit the preferences controller was converted to BaseControllerV2, however the isOnPhishingList hook was not corrected to reference the state properly. The hook will currently always throw which means that link validation fails for Snaps notifications, making them unable to display. This PR corrects that mistake.

Note: This is an edge-case of the Snaps API that doesn't have good E2E coverage yet. We should prioritize that.

Manual testing steps

The following Snap should work correctly and display a notification:

export const onRpcRequest: OnRpcRequestHandler = async ({
  origin,
  request,
}) => {
  switch (request.method) {
    case 'hello':
      return snap.request({
        method: 'snap_notify',
        params: {
          type: 'inApp',
          message: 'Hello! [metamask.io](https://metamask.io)',
        },
      });
    default:
      throw new Error('Method not found.');
  }
};

[metamaskbot]

Builds ready [c7d6e4d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1811 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1482	2145	1818	166	80
		domContentLoaded	1476	2033	1781	161	77
		load	1480	2139	1811	168	81
		domInteractive	25	166	39	31	15
		backgroundConnect	7	105	33	25	12
		firstReactRender	15	94	36	27	13
		getState	45	308	103	62	30
		initialActions	0	0	0	0	0
		loadScripts	1104	1570	1361	141	68
		setupStore	6	80	11	16	8
		uiStartup	1694	2939	2125	339	163

Bundle size diffs [🚀 Bundle size reduced!]

• background: -11 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)