fix: Correct preferences controller usage for isOnPhishingList hook

[FrederikBolding]

Description

In this commit the preferences controller was converted to BaseControllerV2, however the isOnPhishingList hook was not corrected to reference the state properly. The hook will currently always throw which means that link validation fails for Snaps notifications, making them unable to display. This PR corrects that mistake.

Note: This is an edge-case of the Snaps API that doesn't have good E2E coverage yet. We should prioritize that.

Manual testing steps

The following Snap should work correctly and display a notification:

export const onRpcRequest: OnRpcRequestHandler = async ({
  origin,
  request,
}) => {
  switch (request.method) {
    case 'hello':
      return snap.request({
        method: 'snap_notify',
        params: {
          type: 'inApp',
          message: 'Hello! [metamask.io](https://metamask.io)',
        },
      });
    default:
      throw new Error('Method not found.');
  }
};

[metamaskbot]

Builds ready [11006e6]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1921 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	394	2202	1835	365	175
		domContentLoaded	1582	2196	1886	174	84
		load	1619	2203	1921	162	78
		domInteractive	24	86	39	18	9
		backgroundConnect	7	91	35	25	12
		firstReactRender	15	89	21	16	8
		getState	43	211	96	33	16
		initialActions	0	1	0	0	0
		loadScripts	1176	1722	1454	150	72
		setupStore	6	61	10	12	6
		uiStartup	1867	2521	2178	200	96

Bundle size diffs [🚀 Bundle size reduced!]

• background: -11 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)