Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SIWE e2e test timing out and breaking ci #28801

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: SIWE e2e test timing out and breaking ci #28801

merged 3 commits into from
Nov 29, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 29, 2024

Description

SIWE tests are timing out, making our ci broken, as they take very long to execute (there are several instances of waiting for event payload which take 20 seconds each, making reach the total limit of 80 seconds).
This updates the timeout limits for that spec to unblock ci (based on a similar fix @chloeYue did for another long test). The Confirmations team can investigate further if that's expected

Screenshot from 2024-11-29 09-21-45

Screenshot from 2024-11-29 09-06-04

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona self-assigned this Nov 29, 2024
@seaona seaona marked this pull request as ready for review November 29, 2024 09:11
@seaona seaona requested a review from a team as a code owner November 29, 2024 09:11
@seaona seaona changed the title test: timeout test fix: SIWE e2e test timing out and breaking ci Nov 29, 2024
@seaona seaona added this pull request to the merge queue Nov 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c243677]
Page Load Metrics (2338 ± 186 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29928461926805387
domContentLoaded156729332305379182
load157529542338386186
domInteractive31229804923
backgroundConnect7135393316
firstReactRender167736188
getState47135106188
initialActions01000
loadScripts116023301769320153
setupStore66212126
uiStartup184434642691460221
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit cbb57a1 Nov 29, 2024
99 checks passed
@seaona seaona deleted the timeout-test branch November 29, 2024 09:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Nov 29, 2024
@seaona seaona added flaky tests area-qa Relating to QA work (Quality Assurance) labels Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants