feat: log-merge-group-failure #28799

itsyoboieltr · 2024-11-28T20:44:26Z

Description

This PR integrates the new reusable workflow (MetaMask/github-tools#31) that can be used to write data to google sheets when the merge group event fails. Environment variables (= GitHub secrets) are required to configure:

GOOGLE_APPLICATION_CREDENTIALS, GOOGLE_SERVICE_ACCOUNT: The google service account that is used for authentication with the google sheets api.
- The service account needs to have access to the google sheet you intend to operate on. To give access to the google sheet, you need to click the "Share" button in the top-right corner. Enter the service account's email (can be found on google cloud console), give "Editor" permissions. After this, the service account will have access to this spreadsheet, allowing read and write operations.
SPREADSHEET_ID: unique identifier that can be found in the url when you open the google sheet
SHEET_NAME: name of a sheet in a spreadsheet that can be found on the bottom

Short summary of what happens in the workflow:

Google api authentication setup
Check if current date exists in the spreadsheet
If current date exists, increment number of PRs by 1
If current date does not exist, create a new row with the current date, and the number 1 (so that it can be incremented later, if more merge group events fail on the same day).

Spreadsheet here: https://docs.google.com/spreadsheets/d/11niHgT_E2YzzXHXQSxX5LNdA6i0GG5aa-OZWvn7_-o4

Dashboard here: https://lookerstudio.google.com/u/1/reporting/e7e8f90e-72aa-4128-ae01-6305bf3393f4/page/p_pz1dszarmd

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3400

Manual testing steps

When the workflow runs, depending on the state of the spreadsheet:
- If the current date already exists, the number of PRs removed from the merge queue should be incremented by 1.
- If the current date does not exist, a new row should be added with the current date, and the number of PRs should be set to 1.

I created a private repository to test it, and there it worked. The actual production usage can only be tested if we merge and see if anything gets removed from the merge queue, in this case the spreadsheet should get updated.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-28T20:44:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-28T21:18:47Z

Builds ready [48dcefc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1737 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	304	2176	1663	374	180
		domContentLoaded	1433	2101	1707	203	97
		load	1441	2172	1737	212	102
		domInteractive	23	73	39	17	8
		backgroundConnect	7	98	33	30	14
		firstReactRender	15	101	39	28	13
		getState	4	59	12	12	6
		initialActions	0	0	0	0	0
		loadScripts	1013	1585	1244	170	82
		setupStore	6	81	19	22	10
		uiStartup	1604	2509	1985	291	140

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-29T15:57:16Z

Builds ready [90646e1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1542 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1361	1808	1544	130	62
		domContentLoaded	1321	1794	1512	114	55
		load	1363	1810	1542	128	61
		domInteractive	22	75	37	18	8
		backgroundConnect	8	76	30	21	10
		firstReactRender	15	79	27	20	9
		getState	4	50	13	14	7
		initialActions	0	1	0	0	0
		loadScripts	960	1397	1114	105	50
		setupStore	6	67	14	17	8
		uiStartup	1503	2041	1701	139	67

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-29T17:17:07Z

Builds ready [3deebb1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1559 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	437	1721	1510	256	123
		domContentLoaded	1415	1648	1529	61	30
		load	1459	1736	1559	72	34
		domInteractive	23	71	37	15	7
		backgroundConnect	10	88	32	22	10
		firstReactRender	16	73	29	20	10
		getState	4	68	16	19	9
		initialActions	0	0	0	0	0
		loadScripts	1037	1264	1135	63	30
		setupStore	6	57	11	13	6
		uiStartup	1603	1939	1738	81	39

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-29T19:31:23Z

Builds ready [5d703b0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1877 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1600	2254	1879	159	76
		domContentLoaded	1595	2181	1845	147	71
		load	1599	2237	1877	159	77
		domInteractive	26	159	43	29	14
		backgroundConnect	7	60	34	19	9
		firstReactRender	16	92	27	19	9
		getState	50	204	93	33	16
		initialActions	0	0	0	0	0
		loadScripts	1190	1651	1395	120	58
		setupStore	6	97	15	21	10
		uiStartup	1832	2956	2152	246	118

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-04T19:35:59Z

Builds ready [5d703b0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1759 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1533	2040	1758	137	66
		domContentLoaded	1525	1993	1733	130	62
		load	1541	2042	1759	138	66
		domInteractive	23	117	35	20	10
		backgroundConnect	8	57	28	15	7
		firstReactRender	14	29	19	4	2
		getState	104	139	121	10	5
		initialActions	0	0	0	0	0
		loadScripts	1118	1596	1319	123	59
		setupStore	6	18	9	3	2
		uiStartup	1762	2281	2010	146	70

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-04T20:21:22Z

Builds ready [2926a19]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1764 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	225	2042	1623	461	221
		domContentLoaded	1492	2020	1732	111	53
		load	1556	2036	1764	104	50
		domInteractive	23	48	28	6	3
		backgroundConnect	8	91	35	21	10
		firstReactRender	15	87	22	15	7
		getState	75	389	130	75	36
		initialActions	0	1	0	0	0
		loadScripts	1098	1525	1317	97	46
		setupStore	6	80	11	16	8
		uiStartup	1765	2560	2055	206	99

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-09T18:42:29Z

Builds ready [64da49e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2056 ± 169 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	363	2574	1857	570	274
		domContentLoaded	1620	2893	2027	352	169
		load	1684	2929	2056	351	169
		domInteractive	25	107	41	20	10
		backgroundConnect	7	68	28	21	10
		firstReactRender	15	62	24	13	6
		getState	84	363	151	64	31
		initialActions	0	1	0	0	0
		loadScripts	1218	2277	1589	302	145
		setupStore	7	80	13	16	8
		uiStartup	1954	3341	2381	410	197

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

This reverts commit 3ae991b.

metamaskbot · 2024-12-09T19:36:06Z

Builds ready [d4564b7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2587 ± 341 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	384	4038	2077	1034	497
		domContentLoaded	1769	3814	2530	685	329
		load	1823	4050	2587	710	341
		domInteractive	26	175	73	45	22
		backgroundConnect	12	256	61	60	29
		firstReactRender	15	210	48	48	23
		getState	72	264	154	56	27
		initialActions	0	0	0	0	0
		loadScripts	1394	3143	2018	568	273
		setupStore	7	102	17	20	10
		uiStartup	2038	5010	3068	961	461

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

.github/workflows/main.yml

metamaskbot · 2024-12-10T19:38:08Z

Builds ready [1d9944b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1934 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1672	2394	1934	190	91
		domContentLoaded	1626	2325	1899	187	90
		load	1671	2390	1934	189	91
		domInteractive	25	102	42	20	10
		backgroundConnect	11	63	27	18	9
		firstReactRender	15	92	28	22	10
		getState	81	305	139	55	27
		initialActions	0	0	0	0	0
		loadScripts	1252	1870	1502	166	80
		setupStore	7	24	9	4	2
		uiStartup	1871	2944	2258	270	130

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

danjm

LGTM

DDDDDanica · 2024-12-11T17:12:28Z

LGTM ! Good job !

dbrans · 2024-12-11T17:58:20Z

Irony: if this PR gets removed from the merge queue.

Nice work @itsyoboieltr !

itsyoboieltr added 2 commits November 29, 2024 00:37

feat: log-merge-group-failure

4ae2f0a

rename

48dcefc

itsyoboieltr self-assigned this Nov 28, 2024

itsyoboieltr requested a review from a team as a code owner November 28, 2024 20:44

metamaskbot added the team-extension-platform label Nov 28, 2024

Update main.yml

90646e1

Update main.yml

3deebb1

Merge branch 'develop' into feat/log-merge-group-failure

5d703b0

feat: circleci

2926a19

itsyoboieltr requested a review from a team as a code owner December 4, 2024 19:52

itsyoboieltr added 2 commits December 9, 2024 21:42

Merge branch 'main' into feat/log-merge-group-failure

0307f08

fix: update commit hash

64da49e

test

3ae991b

itsyoboieltr force-pushed the feat/log-merge-group-failure branch from f2dbecf to 3ae991b Compare December 9, 2024 18:52

itsyoboieltr added 2 commits December 9, 2024 22:52

Revert "test"

89dab09

This reverts commit 3ae991b.

Update main.yml

d4564b7

danjm reviewed Dec 10, 2024

View reviewed changes

.github/workflows/main.yml Outdated Show resolved Hide resolved

feat: update commit hash

1d9944b

itsyoboieltr requested review from danjm and Gudahtt December 10, 2024 19:07

danjm approved these changes Dec 10, 2024

View reviewed changes

DDDDDanica approved these changes Dec 11, 2024

View reviewed changes

itsyoboieltr added this pull request to the merge queue Dec 11, 2024

Merged via the queue into main with commit 2bd3db8 Dec 11, 2024
77 checks passed

itsyoboieltr deleted the feat/log-merge-group-failure branch December 11, 2024 17:58

github-actions bot locked and limited conversation to collaborators Dec 11, 2024

metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: log-merge-group-failure #28799

feat: log-merge-group-failure #28799

itsyoboieltr commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 9, 2024

metamaskbot commented Dec 9, 2024

metamaskbot commented Dec 10, 2024

danjm left a comment

DDDDDanica commented Dec 11, 2024

dbrans commented Dec 11, 2024

feat: log-merge-group-failure #28799

feat: log-merge-group-failure #28799

Conversation

itsyoboieltr commented Nov 28, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 9, 2024

metamaskbot commented Dec 9, 2024

metamaskbot commented Dec 10, 2024

danjm left a comment

Choose a reason for hiding this comment

DDDDDanica commented Dec 11, 2024

dbrans commented Dec 11, 2024

itsyoboieltr commented Nov 28, 2024 •

edited

Loading