test: [POM] improve homepage class implementation

[chloeYue]

Description

The current homepage class contains methods for asset, NFT, and activity lists, resulting in a long file that can make it challenging to locate specific methods. To improve organization and maintainability, I have refactored the homepage into four separate class files:

• homepage
• asset_list
• nft_list
• activity_list

Changes:
Refactoring: Split the methods into respective class files to streamline the structure and make the codebase more modular.
Method update: Removed the waitUntilAssetListHasItems method, as it duplicates the functionality of the existing check_tokenListItem method.

I added the skip-e2e-quality-gatelabel, as this PR involves many import line changes in test specs. However, there are no functional changes for tests and methods in this PR, i have only splitted original functions in different files.

Related issues

Fixes:

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [5195efb]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1897 ± 143 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1526	2389	1903	301	145
		domContentLoaded	1519	2338	1858	292	140
		load	1527	2388	1897	298	143
		domInteractive	24	107	45	25	12
		backgroundConnect	8	75	36	24	11
		firstReactRender	15	55	29	15	7
		getState	44	122	83	24	11
		initialActions	0	1	0	0	0
		loadScripts	1107	1854	1434	252	121
		setupStore	6	17	8	3	1
		uiStartup	1757	2625	2139	332	159

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [2cffd27]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1841 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1524	2454	1847	235	113
		domContentLoaded	1505	2441	1819	231	111
		load	1522	2460	1841	234	112
		domInteractive	23	59	31	10	5
		backgroundConnect	6	76	22	19	9
		firstReactRender	14	91	29	19	9
		getState	46	184	93	30	15
		initialActions	0	1	0	0	0
		loadScripts	1119	1827	1379	189	91
		setupStore	6	39	10	7	3
		uiStartup	1741	2835	2113	279	134

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[seaona]

I really like this refactor! thanks @chloeYue 🙌 Skipping the quality gate also makes sense to me

[metamaskbot]

Builds ready [2f63212]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1985 ± 155 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	397	2495	1705	606	291
		domContentLoaded	1480	2547	1959	318	153
		load	1498	2570	1985	324	155
		domInteractive	24	182	44	36	17
		backgroundConnect	8	82	28	21	10
		firstReactRender	15	86	32	24	11
		getState	47	191	104	41	20
		initialActions	0	1	0	0	0
		loadScripts	1034	1988	1491	278	134
		setupStore	6	80	14	17	8
		uiStartup	1714	3042	2333	324	155

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

Thanks @chloeYue for breaking down the pages to make them modular, clear and maintainable. I noted some observations in the other files, which will be addressed later as mentioned by you.