feat: migrate AppStateController to inherit from BaseController V2

[cryptodev-2s]

Description

This PR migrate AppStateController to inherit from BaseController V2

Related issues

Fixes: #25916

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [ae7e263]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2124 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	317	2487	1750	699	336
		domContentLoaded	1696	2430	2090	193	93
		load	1711	2457	2124	188	90
		domInteractive	27	79	42	14	7
		backgroundConnect	7	190	37	40	19
		firstReactRender	15	68	30	19	9
		getState	31	89	64	20	9
		initialActions	0	1	0	0	0
		loadScripts	1252	1897	1589	159	77
		setupStore	6	12	8	2	1
		uiStartup	2028	2806	2431	212	102

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.24 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [5c939d9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1895 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	716	2218	1840	286	138
		domContentLoaded	1618	2200	1865	119	57
		load	1638	2214	1895	119	57
		domInteractive	27	58	34	8	4
		backgroundConnect	9	90	32	25	12
		firstReactRender	16	96	30	23	11
		getState	48	206	106	35	17
		initialActions	0	1	0	0	0
		loadScripts	1201	1776	1433	121	58
		setupStore	7	10	8	1	0
		uiStartup	1843	2765	2216	212	102

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.24 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [da09c89]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1741 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1563	2007	1749	131	63
		domContentLoaded	1534	1981	1716	128	61
		load	1545	1990	1741	135	65
		domInteractive	24	376	57	78	38
		backgroundConnect	6	69	28	20	10
		firstReactRender	15	92	24	18	8
		getState	45	172	85	30	14
		initialActions	0	1	0	0	0
		loadScripts	1088	1579	1300	130	63
		setupStore	6	48	12	9	5
		uiStartup	1768	2442	1992	181	87

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.15 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[mcmire]

A few minor things, but otherwise looks pretty good to me!

[metamaskbot]

Builds ready [29e80ef]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2263 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	327	2674	2083	554	266
		domContentLoaded	1993	2616	2227	191	92
		load	1998	2646	2263	208	100
		domInteractive	29	76	52	18	8
		backgroundConnect	6	206	35	45	21
		firstReactRender	16	92	31	19	9
		getState	146	448	196	84	40
		initialActions	0	1	0	0	0
		loadScripts	1505	2010	1706	165	79
		setupStore	7	81	15	16	8
		uiStartup	2280	3322	2685	327	157

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.15 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[mcmire]

One more thing.

[metamaskbot]

Builds ready [ad49836]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2005 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1757	2340	2004	146	70
		domContentLoaded	1747	2300	1966	148	71
		load	1759	2338	2005	149	71
		domInteractive	26	71	39	14	7
		backgroundConnect	9	93	35	23	11
		firstReactRender	16	96	28	22	11
		getState	105	330	160	57	27
		initialActions	0	1	0	0	0
		loadScripts	1333	1777	1534	124	60
		setupStore	7	78	13	15	7
		uiStartup	2049	3145	2353	258	124

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.15 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[mikesposito]

LGTM!

I tested this branch locally and I didn't experience issues

[mcmire]

Tested calling eth_requestAccounts when the extension was locked. Once it was unlocked then the request went through.

Also tried setting the autolock timer to 1 minute, and indeed the extension autolocked after 1 minute.

[desi]

LGTM based on code and thumbs up from others around review and testing