feat: migrate AppMedataController to inherit from BaseController V2

[cryptodev-2s]

Description

This PR migrate AppMedataController to inherit from BaseController V2

Related issues

Fixes: #28467

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [0ec4c18]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1616 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	300	1811	1533	295	142
		domContentLoaded	1442	1950	1598	118	57
		load	1492	1954	1616	114	55
		domInteractive	23	69	37	15	7
		backgroundConnect	7	58	21	14	7
		firstReactRender	15	72	33	22	11
		getState	4	22	7	4	2
		initialActions	0	1	0	0	0
		loadScripts	1048	1463	1172	93	45
		setupStore	6	62	21	21	10
		uiStartup	1676	2150	1798	119	57

Bundle size diffs [🚀 Bundle size reduced!]

• background: -60 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[mcmire]

A few things, but other than that, good to go.

[mcmire]

Looks good!

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [4473585]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1642 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	344	2013	1571	305	146
		domContentLoaded	1391	1994	1612	119	57
		load	1432	2080	1642	131	63
		domInteractive	17	77	32	13	6
		backgroundConnect	9	87	35	23	11
		firstReactRender	15	74	33	22	10
		getState	4	47	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1002	1452	1184	97	47
		setupStore	6	51	14	14	7
		uiStartup	1552	2272	1825	142	68

Bundle size diffs [🚀 Bundle size reduced!]

• background: -60 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)