feat: Migrate remaining e2e tests to redesigned confirmations

[pedronfigueiredo]

Description

Below are the test files that are migrated on this PR. This includes creating duplicate tests that rely on tempToggleSettingRedesignedTransactionConfirmations, removing it in those duplicates and making the necessary changes so that those tests pass.

• test/e2e/json-rpc/eth_sendTransaction.spec.js
• test/e2e/tests/account/add-account.spec.ts
• test/e2e/tests/petnames/petnames-transactions.spec.js
• test/e2e/tests/ppom/ppom-blockaid-alert-simple-send.spec.js
• test/e2e/tests/responsive-ui/metamask-responsive-ui.spec.js
• test/e2e/tests/tokens/custom-token-send-transfer.spec.js
• test/e2e/tests/transaction/change-assets.spec.js
• test/e2e/tests/transaction/edit-gas-fee.spec.js
• test/e2e/tests/transaction/gas-estimates.spec.js
• test/e2e/tests/transaction/multiple-transactions.spec.js
• test/e2e/tests/transaction/navigate-transactions.spec.js
• test/e2e/tests/transaction/send-edit.spec.js
• test/e2e/tests/transaction/send-eth.spec.js
• test/e2e/tests/transaction/send-hex-address.spec.js

On a subsequent ticket that removes the old confirmation flow (https://github.com/MetaMask/MetaMask-planning/issues/3030), the original tests that rely on tempToggleSettingRedesignedTransactionConfirmations to pass and to test the old confirmation flows will be deleted.

Additionally, the following e2e tests will not be migrated to redesigned confirmations, and will also be deleted on https://github.com/MetaMask/MetaMask-planning/issues/3030.

• test/e2e/tests/dapp-interactions/contract-interactions.spec.js
• test/e2e/tests/dapp-interactions/dapp-tx-edit.spec.js
• test/e2e/tests/dapp-interactions/failing-contract.spec.js
• test/e2e/tests/network/network-error.spec.js
• test/e2e/tests/settings/4byte-directory.spec.js
• test/e2e/tests/settings/show-hex-data.spec.js
• test/e2e/tests/tokens/custom-token-add-approve.spec.js
• test/e2e/tests/tokens/increase-token-allowance.spec.js
• test/e2e/tests/transaction/simple-send.spec.ts
• test/e2e/tests/tokens/nft/erc721-interaction.spec.js
• test/e2e/tests/tokens/nft/erc1155-interaction.spec.js
• test/e2e/tests/tokens/nft/send-nft.spec.js

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3700

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [f5fc220]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1866 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	316	2255	1720	488	234
		domContentLoaded	1587	2245	1842	150	72
		load	1636	2257	1866	152	73
		domInteractive	25	80	36	13	6
		backgroundConnect	8	72	23	19	9
		firstReactRender	16	87	25	18	8
		getState	54	205	106	27	13
		initialActions	0	1	0	0	0
		loadScripts	1170	1741	1409	140	67
		setupStore	6	19	9	3	1
		uiStartup	1927	2456	2146	156	75

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 107 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [913964d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2005 ± 133 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1563	2555	2003	280	134
		domContentLoaded	1555	2508	1967	259	124
		load	1564	2565	2005	278	133
		domInteractive	25	112	45	22	11
		backgroundConnect	10	173	36	37	18
		firstReactRender	15	25	20	3	2
		getState	83	315	145	43	21
		initialActions	0	1	0	0	0
		loadScripts	1153	1890	1514	218	105
		setupStore	7	83	13	16	8
		uiStartup	1846	3294	2307	352	169

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 107 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[chloeYue]

LGTM