-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Capture raw 4byte hex #28773
Merged
Merged
fix: Capture raw 4byte hex #28773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [093972c]
Page Load Metrics (1823 ± 98 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
previously approved these changes
Nov 28, 2024
Builds ready [8dbfd5e]
Page Load Metrics (1875 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Dec 4, 2024
matthewwalsh0
approved these changes
Dec 5, 2024
Builds ready [90e2d29]
Page Load Metrics (1846 ± 43 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.10.0
Issue or pull request that will be included in release 12.10.0
label
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.10.0
Issue or pull request that will be included in release 12.10.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to include in the events the property
transaction_contract_method_4byte
to improve the metrics when we are not able to identify the name of the function with our current sources.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3468
Manual testing steps
Screenshots/Recordings
4byte-event.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist