Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capture raw 4byte hex #28773

Merged
merged 5 commits into from
Dec 5, 2024
Merged

fix: Capture raw 4byte hex #28773

merged 5 commits into from
Dec 5, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Nov 27, 2024

Description

This PR aims to include in the events the property transaction_contract_method_4byte to improve the metrics when we are not able to identify the name of the function with our current sources.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3468

Manual testing steps

  1. Go to this page test dapp
  2. Deploy a contract
  3. Click in Mint and check Segment events

Screenshots/Recordings

4byte-event.webm

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Nov 27, 2024
@vinistevam vinistevam requested a review from a team as a code owner November 27, 2024 14:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [093972c]
Page Load Metrics (1823 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15672288183020498
domContentLoaded15552215179519091
load15682294182320498
domInteractive279641209
backgroundConnect895292512
firstReactRender1781372311
getState460242110
initialActions01000
loadScripts11081718133017283
setupStore665182010
uiStartup174124932045217104
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 138 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

OGPoyraz
OGPoyraz previously approved these changes Nov 28, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8dbfd5e]
Page Load Metrics (1875 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15772230186916378
domContentLoaded15702213184415675
load16342227187515976
domInteractive24158403015
backgroundConnect999252311
firstReactRender1495262311
getState953891607335
initialActions01000
loadScripts11871733142213766
setupStore78914199
uiStartup185528042226281135
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 138 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [90e2d29]
Page Load Metrics (1846 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1704199318459345
domContentLoaded1687197018088340
load1708198418469043
domInteractive2310134188
backgroundConnect1171372010
firstReactRender16291932
getState873211374622
initialActions00000
loadScripts1277151413947536
setupStore67911167
uiStartup19352764212817383
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 138 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@vinistevam vinistevam added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c375dd5 Dec 5, 2024
75 checks passed
@vinistevam vinistevam deleted the fix/capture-4byte-hex-signature branch December 5, 2024 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants