chore: Update @metamask/gas-fee-controller and peer deps

[Gudahtt]

Description

Update the @metamask/gas-fee-controller package to v21 to satisfy the peer dependency on @metamask/network-controller@^21.0.0, and update the @metamask/user-operation-controller to satisfy its peer dependency upon @metamask/gas-fee-controller.

Note that an older version of @metamask/gas-fee-controller (v18) remains in the dependency tree, but only because it's imported by @metamask/smart-transaction-controller for type reasons. It has no runtime impact on the application, so the associated peer dependency warnings from this older release can be ignored. This will be eliminated soon, in an upcoming PR.

The updated @metamask/user-operation-controller still does not have its peer dependencies satisfied, but the problems are pre-existing. The @metamask/keyring-controller and @metamask/transaction-controller packages are head of where this package expects them to be. This is not made worse by this PR though, and will be addressed in a future PR.

Changelogs:

• @metamask/gas-fee-controller@21: https://github.com/MetaMask/core/blob/main/packages/gas-fee-controller/CHANGELOG.md#2100
  • One breaking change with an impact:

    The inherited AbstractPollingController method startPollingByNetworkClientId has been renamed to startPolling (feat: make polling input generic core#4752)

• @metamask/user-operation-controller@16: https://github.com/MetaMask/core/blob/main/packages/user-operation-controller/CHANGELOG.md#1600
  • No breaking changes with an impact. It appeared at first that the startPollingByNetworkClientId was breaking, but the user operation controller had an override for that method so it was preserved (see here)

Related issues

Related to https://github.com/MetaMask/MetaMask-planning/issues/3568

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[Gudahtt]

This resolution was already unused. Not directly related to the bump here, but couldn't hurt to remove it.

[Gudahtt]

@metamaskbot update-policies

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	0	220 kB	metamaskbot
npm/@metamask/[email protected]	None	0	104 kB	metamaskbot
npm/@metamask/[email protected]	network	0	483 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [243ee18]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1696 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	233	2221	1626	359	172
		domContentLoaded	1516	2206	1665	160	77
		load	1537	2223	1696	166	80
		domInteractive	18	82	35	16	8
		backgroundConnect	8	93	32	25	12
		firstReactRender	18	76	44	24	11
		getState	5	62	20	19	9
		initialActions	0	1	0	0	0
		loadScripts	1090	1655	1228	130	62
		setupStore	7	52	15	15	7
		uiStartup	1731	2515	1903	204	98

Bundle size diffs [🚀 Bundle size reduced!]

• background: -63.78 KiB (-1.08%)
• ui: 0 Bytes (0.00%)
• common: -9.73 KiB (-0.12%)

[mcmire]

Makes sense, looks good.

[cryptotavares]

Looks good 🚀