test: Allow token balance to populate after swap #28744
Merged
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [5d3cfd0]
Page Load Metrics (1652 ± 42 ms)
Bundle size diffs
|
Builds ready [04fca2d]
Page Load Metrics (1726 ± 61 ms)
Bundle size diffs
|
davibroc
force-pushed
the
test/fix-zero-balance
branch
from
04fca2d to
6eda1a5
Compare
Builds ready [6eda1a5]
Page Load Metrics (1942 ± 123 ms)
Bundle size diffs
|
davibroc
force-pushed
the
test/fix-zero-balance
branch
from
9734c2d to
6ed9fd5
Compare
Builds ready [6ed9fd5]
Page Load Metrics (1947 ± 51 ms)
Bundle size diffs
|
Builds ready [cfa41a1]
Page Load Metrics (1776 ± 74 ms)
Bundle size diffs
|
chloeYue
reviewed
Dec 2, 2024
| @@ -82,6 +84,8 @@ testSet.forEach((options) => { | |||
| await walletPage.selectTokenWallet(); | |||
| await networkController.selectNetwork(options.network); | |||
| await walletPage.selectSwapAction(); | |||
| // Allow balance label to populate | |||
| await walletPage.page.waitForTimeout(3000); | |||
There was a problem hiding this comment.
Do we have a dynamic way to wait for the balance label to populate?
There was a problem hiding this comment.
Unfortunately not in this case like I did above. If I click and open the control and wait to populate it will never populate it will always stay zero.
chloeYue
approved these changes
Dec 2, 2024
racitores
approved these changes
Dec 2, 2024
| @@ -54,6 +59,8 @@ export class WalletPage { | |||
| await this.importAccountButton.click(); | |||
| await this.page.fill('#private-key-box', accountPK); | |||
| await this.importAccountConfirmBtn.click(); | |||
| await this.page.waitForTimeout(2000); | |||
There was a problem hiding this comment.
Is this mandatory? is not possible to change it for a locator?
metamaskbot
added
the
release-12.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After importing the test account which contains the funds to execute the swaps it takes a few seconds before the balance would show up in the wallet. So I added steps to the script to pause and wait for that balance to show up before executing the tests.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist