Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump @metamask/permission-controller to ^11.0.0 #28743

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Nov 26, 2024

Description

Bumps @metamask/permission-controller to ^11.0.0 and adopt breaking changes

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

No changes in behavior.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jiexi jiexi changed the title Bump @metamask/permission-controller to ^11.0.0 feat: Bump @metamask/permission-controller to ^11.0.0 Nov 26, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title feat: Bump @metamask/permission-controller to ^11.0.0 feat: Bump @metamask/permission-controller to ^11.0.0 Nov 26, 2024
adonesky1
adonesky1 previously approved these changes Nov 26, 2024
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiexi jiexi marked this pull request as ready for review November 26, 2024 20:03
@jiexi jiexi requested a review from a team as a code owner November 26, 2024 20:03
@jiexi
Copy link
Contributor Author

jiexi commented Nov 26, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiexi jiexi enabled auto-merge November 26, 2024 20:35
@jiexi jiexi added this pull request to the merge queue Nov 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4653b83]
Page Load Metrics (1852 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27221671789382183
domContentLoaded15722096182514570
load15852173185214971
domInteractive2387452311
backgroundConnect117528199
firstReactRender18104452713
getState57417199
initialActions01000
loadScripts11491674135812761
setupStore65213126
uiStartup17432596209419795
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39.87 KiB (-0.67%)
  • ui: 10 Bytes (0.00%)
  • common: -239.72 KiB (-2.86%)

@Gudahtt
Copy link
Member

Gudahtt commented Nov 26, 2024

background: -39.87 KiB (-0.67%)
ui: 10 Bytes (0.00%)
common: -239.72 KiB (-2.86%)

Nice bundle size reduction

Merged via the queue into develop with commit 86d6c05 Nov 26, 2024
75 checks passed
@jiexi jiexi deleted the jl/bump-permission-controller-11.0.0 branch November 26, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants