Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add E2E spec for auto grant new permitted chain to connected dapp when network is switched via popup #28741

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Nov 26, 2024

Description

This PR adds an E2E test to cover the auto grant previously unpermitted chain on network switch via wallet popup

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title fix: Fix auto grant new permitted chain to dapp when network is switched fix: Fix auto grant new permitted chain to connected dapp when network is switched Nov 26, 2024
@jiexi jiexi changed the title fix: Fix auto grant new permitted chain to connected dapp when network is switched fix: Fix auto grant new permitted chain to connected dapp when network is switched via popup Nov 26, 2024
@jiexi jiexi changed the title fix: Fix auto grant new permitted chain to connected dapp when network is switched via popup test: Add E2E spec for auto grant new permitted chain to connected dapp when network is switched via popup Nov 26, 2024
@jiexi
Copy link
Contributor Author

jiexi commented Nov 26, 2024

this doesn't work because the activeTabOrigin view doesn't have a network list menu component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants