Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content dialog styling is being applied to all dialogs #28739

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Nov 26, 2024

Description

Problem: A scss change for preventing modal scrolling in the bridge experience was added and got unintentionally applied to all modals.

Solution: Nest the styling within the quotes-modal className

Open in GitHub Codespaces

Related issues

Fixes: #28722

Manual testing steps

  1. Visually inspect Swap token picker
  2. Visually inspect tx "Speed up" and "Cancel" layout

Screenshots/Recordings

Before

See bug report screenshots

After

Screenshot 2024-11-26 at 9 48 13 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae force-pushed the bug28722-modal-misalignment branch from d243bb9 to 73428fb Compare November 26, 2024 17:50
@micaelae micaelae marked this pull request as ready for review November 26, 2024 17:51
@micaelae micaelae requested a review from a team as a code owner November 26, 2024 17:51
@metamaskbot
Copy link
Collaborator

Builds ready [73428fb]
Page Load Metrics (1779 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15602244177714670
domContentLoaded15352204174814368
load15642249177914670
domInteractive256837126
backgroundConnect1282322010
firstReactRender1782322110
getState562262110
initialActions01000
loadScripts10751637126911856
setupStore65917189
uiStartup17412497198415976
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 3f574c4 Nov 26, 2024
80 checks passed
@micaelae micaelae deleted the bug28722-modal-misalignment branch November 26, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Misalignment in send, speed up, cancel and swaps screens
4 participants