feat: multichain send action adds solana #28738

aganglada · 2024-11-26T17:07:41Z

Description

Added support for Solana on the Send button action.
When the user click on Send from the BTC snap, it will open the BTC send flow.
When the user click on Send from the Solana snap, it will open the Solana send flow.

Related issues

Fixes:

Manual testing steps

As of right now, manually testing is a bit complex, it needs to run the snap manually and the extension, since we 1st need to publish a new release to npm with more up to date work. The snap version we have in npm is outdated and won't support this flow. That said, if you want to go ahead and run locally the steps are the following:

Clone the Solana Snap monorepo and run it locally with yarn and then yarn start
In the extension, at this branch, apply the following changes and run the extension as flask:

At builds.yml add the solana feature to the flask build:
 
     features:
       - build-flask
       - keyring-snaps
+      - solana

At shared/lib/accounts/solana-wallet-snap.ts point the snap ID to the snap localhost:

-export const SOLANA_WALLET_SNAP_ID: SnapId = SolanaWalletSnap.snapId as SnapId;
+//export const SOLANA_WALLET_SNAP_ID: SnapId = SolanaWalletSnap.snapId as SnapId;
+export const SOLANA_WALLET_SNAP_ID: SnapId = "local:http://localhost:8080/";

Manually install the snap via the snap dapp at http://localhost:3000
Enable the Solana account via Settings > Experimental > Enable Solana account
Create a Solana account from the account-list menu and see the account overview of it

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-26T17:07:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-26T17:45:00Z

Builds ready [d16127a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1787 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1581	2093	1798	137	66
		domContentLoaded	1564	2079	1758	137	66
		load	1584	2096	1787	141	68
		domInteractive	27	78	42	15	7
		backgroundConnect	7	71	29	16	8
		firstReactRender	16	75	40	23	11
		getState	4	63	28	22	11
		initialActions	0	0	0	0	0
		loadScripts	1150	1576	1314	118	57
		setupStore	6	55	13	14	7
		uiStartup	1773	2390	1990	165	79

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 16 Bytes (0.00%)

ui/components/app/wallet-overview/coin-buttons.tsx

shared/lib/accounts/snaps.ts

ui/components/app/wallet-overview/coin-buttons.tsx

metamaskbot · 2024-11-28T10:20:40Z

Builds ready [55adb73]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2033 ± 123 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	364	2777	1814	629	302
		domContentLoaded	1697	2630	2005	241	116
		load	1711	2723	2033	256	123
		domInteractive	27	87	41	17	8
		backgroundConnect	9	86	30	21	10
		firstReactRender	16	86	26	17	8
		getState	24	117	68	23	11
		initialActions	0	1	0	0	0
		loadScripts	1293	2096	1537	202	97
		setupStore	6	56	11	10	5
		uiStartup	2081	3022	2328	236	113

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -7 Bytes (-0.00%)
common: 16 Bytes (0.00%)

metamaskbot · 2024-11-28T11:31:45Z

Builds ready [3d6eb8f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2077 ± 151 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	383	2668	1796	649	312
		domContentLoaded	1702	2625	2054	309	149
		load	1711	2653	2077	314	151
		domInteractive	24	106	51	24	12
		backgroundConnect	9	79	28	26	12
		firstReactRender	15	133	32	29	14
		getState	61	219	116	38	18
		initialActions	0	1	0	0	0
		loadScripts	1217	2092	1574	260	125
		setupStore	7	77	13	15	7
		uiStartup	1897	3471	2442	429	206

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -7 Bytes (-0.00%)
common: 16 Bytes (0.00%)

metamaskbot · 2024-11-28T12:19:55Z

Builds ready [d34c35f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1659 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	2059	1601	319	153
		domContentLoaded	1479	1955	1641	97	46
		load	1515	1978	1659	97	46
		domInteractive	22	67	37	15	7
		backgroundConnect	6	59	20	16	8
		firstReactRender	14	84	21	17	8
		getState	40	120	76	23	11
		initialActions	0	1	0	0	0
		loadScripts	1109	1527	1271	85	41
		setupStore	6	47	9	9	4
		uiStartup	1660	2302	1872	146	70

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: -7 Bytes (-0.00%)
common: 16 Bytes (0.00%)

aganglada self-assigned this Nov 26, 2024

aganglada requested a review from a team as a code owner November 26, 2024 17:07

metamaskbot added the team-sol PRs from the Solana snap team label Nov 26, 2024

ccharly reviewed Nov 27, 2024

View reviewed changes

ui/components/app/wallet-overview/coin-buttons.tsx Outdated Show resolved Hide resolved

ccharly reviewed Nov 27, 2024

View reviewed changes

ui/components/app/wallet-overview/coin-buttons.tsx Outdated Show resolved Hide resolved

ui/components/app/wallet-overview/coin-buttons.tsx Outdated Show resolved Hide resolved

aganglada force-pushed the SOL-39-extension-send-button-action branch from 37f909c to 7f13bbe Compare November 27, 2024 12:35

ccharly reviewed Nov 27, 2024

View reviewed changes

ui/components/app/wallet-overview/coin-buttons.tsx Outdated Show resolved Hide resolved

shared/lib/accounts/snaps.ts Outdated Show resolved Hide resolved

aganglada force-pushed the SOL-39-extension-send-button-action branch from 7f13bbe to b63c306 Compare November 27, 2024 14:14

aganglada added 5 commits November 27, 2024 18:35

feat: multichain send action adds solana

0d24279

chore: review fixes

5d00236

chore: updaet jsdoc

04bb27c

chore: fix lint issues

3603125

chore: build

78ead8f

aganglada force-pushed the SOL-39-extension-send-button-action branch from d9d8744 to 78ead8f Compare November 27, 2024 17:37

Merge branch 'develop' into SOL-39-extension-send-button-action

97940ab

ccharly reviewed Nov 28, 2024

View reviewed changes

ui/components/app/wallet-overview/coin-buttons.tsx Show resolved Hide resolved

chore: review fixes

55adb73

aganglada added 3 commits November 28, 2024 11:31

Merge branch 'develop' into SOL-39-extension-send-button-action

1ef534b

chore: fix test

bd842d3

chore: fix test

3d6eb8f

zone-live previously approved these changes Nov 28, 2024

View reviewed changes

chore: review fixes

d34c35f

aganglada dismissed zone-live’s stale review via d34c35f November 28, 2024 11:47

zone-live approved these changes Nov 28, 2024

View reviewed changes

ccharly approved these changes Nov 28, 2024

View reviewed changes

aganglada added this pull request to the merge queue Nov 28, 2024

Merged via the queue into develop with commit 827ae99 Nov 28, 2024
75 checks passed

aganglada deleted the SOL-39-extension-send-button-action branch November 28, 2024 13:29

github-actions bot locked and limited conversation to collaborators Nov 28, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: multichain send action adds solana #28738

feat: multichain send action adds solana #28738

aganglada commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

feat: multichain send action adds solana #28738

feat: multichain send action adds solana #28738

Conversation

aganglada commented Nov 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

metamaskbot commented Nov 28, 2024

aganglada commented Nov 26, 2024 •

edited

Loading