Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:updated account name and length for dapp connections #28725

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

NidhiKJha
Copy link
Member

This PR is to:

  1. Show correct account names when dapp tries to connect with MM and account is imported
  2. Show correct length of accounts when more than one account is connected

Related issues

Fixes: 3685-planning
#28312

Manual testing steps

  1. Import an account in MM
  2. Initiate connection request from Dapp, check correct name of account is shown on connections page
  3. After connecting, select more than account, check length of accounts shown is correct

Screenshots/Recordings

Before

383819102-d87758b9-b17e-47e9-b88f-bf5740ea1e95.mov

After

Screen.Recording.2024-11-26.at.12.58.10.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner November 26, 2024 12:59
@metamaskbot metamaskbot added team-wallet-ux INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [940226f]
Page Load Metrics (2037 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint180329832042234113
domContentLoaded179329391998233112
load180229612037230111
domInteractive288752199
backgroundConnect1084322411
firstReactRender1787522612
getState776292311
initialActions01000
loadScripts12792149148117885
setupStore75916157
uiStartup204333182289262126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 26, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 43e9514 Nov 26, 2024
85 of 86 checks passed
@NidhiKJha NidhiKJha deleted the fix-3685 branch November 26, 2024 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants