Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Snaps packages #28678

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chore: Bump Snaps packages #28678

merged 2 commits into from
Nov 26, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 25, 2024

Description

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:

  • Add snap_getInterfaceContext JSON-RPC method
  • Emit snapInstalled and snapUpdated events for preinstalled Snaps
    • This indirectly makes preinstalled Snaps trigger cronjobs and lifecycle hooks more reliably.

Closes MetaMask/snaps#2899
Closes MetaMask/snaps#2901

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Nov 25, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 25, 2024 10:27
Copy link

socket-security bot commented Nov 25, 2024

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [7b5031c]
Page Load Metrics (2204 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43826082112441212
domContentLoaded185325822178211101
load187025972204219105
domInteractive278546189
backgroundConnect11109322612
firstReactRender521781293416
getState76218178
initialActions00000
loadScripts13561986164018388
setupStore75719189
uiStartup210128902462232111
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 454 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 2.98 KiB (0.04%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:
- Add `snap_getInterfaceContext` JSON-RPC method
- Emit `snapInstalled` and `snapUpdated` events for preinstalled Snaps
- This indirectly makes preinstalled Snaps trigger cronjobs and
lifecycle hooks more reliably.

Closes MetaMask/snaps#2899
Closes MetaMask/snaps#2901

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28678?quickstart=1)
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to a manual request Nov 25, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit a6e1a74 Nov 26, 2024
75 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v79 branch November 26, 2024 11:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-snaps-platform Snaps Platform team
Projects
None yet
4 participants