Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: speed up process error is not displayed when using ledger #28677

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Akaryatrh
Copy link
Contributor

@Akaryatrh Akaryatrh commented Nov 25, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [3d95c83]
Page Load Metrics (1863 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32921671808358172
domContentLoaded1590207418299948
load16012089186311053
domInteractive168145189
backgroundConnect1096372713
firstReactRender653041367435
getState595353014
initialActions01000
loadScripts1160155613578139
setupStore65713147
uiStartup18102653216020297
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 3.95 KiB (0.05%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants