-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Provide selector that enables cross-chain polling, regardless of network filter state #28662
Merged
gambinish
merged 5 commits into
develop
from
fix/current-network-zero-balance-aggregate-bug
Nov 26, 2024
Merged
fix: Provide selector that enables cross-chain polling, regardless of network filter state #28662
gambinish
merged 5 commits into
develop
from
fix/current-network-zero-balance-aggregate-bug
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to ensure cross-chain balances appear as expected
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
changed the title
fix: Temporarily disable isTokenNetworkFilterEqualCurrentNetwork chec…
fix: Temporarily disable isTokenNetworkFilterEqualCurrentNetwork
Nov 22, 2024
Prithpal-Sooriya
previously approved these changes
Nov 22, 2024
Prithpal-Sooriya
previously approved these changes
Nov 22, 2024
Builds ready [77a79e2]
Page Load Metrics (2061 ± 85 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
sahar-fehri
previously approved these changes
Nov 22, 2024
EitchEss
approved these changes
Nov 24, 2024
gambinish
added
DO-NOT-MERGE
Pull requests that should not be merged
and removed
DO-NOT-MERGE
Pull requests that should not be merged
labels
Nov 25, 2024
gambinish
dismissed stale reviews from sahar-fehri and Prithpal-Sooriya
via
November 25, 2024 19:45
57c1412
gambinish
added
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
and removed
DO-NOT-MERGE
Pull requests that should not be merged
labels
Nov 25, 2024
Builds ready [57c1412]
Page Load Metrics (1755 ± 55 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
changed the title
fix: Temporarily disable isTokenNetworkFilterEqualCurrentNetwork
fix: Provide selector that enables cross-chain polling, regardless of network filter state
Nov 25, 2024
sahar-fehri
reviewed
Nov 26, 2024
salimtb
reviewed
Nov 26, 2024
sahar-fehri
approved these changes
Nov 26, 2024
Builds ready [8d8c222]
Page Load Metrics (2012 ± 156 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Nov 26, 2024
metamaskbot
added
the
release-12.9.0
Issue or pull request that will be included in release 12.9.0
label
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We cannot rely on the same selector for all cases, as not all UI is tightly coupled to the tokenNetworkFilter, else we will not be able to compute aggregated balances across chains, when filtered by current network. Since polling for balances is UI based, we can use a different selector on the network-filter, which should execute polling loops only when the dropdown is toggled open.
With the current behavior, the aggregated balance will only display when "All Networks" filter is selected, and when the "Current Network" is selected, it will aggregate balances only for that chain.
Related issues
Fixes: Current chain aggregated balance showing up in cross chain aggregated balance when current network is filterd.
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist