Cherry pick E2E changes #28648
Closed
Cherry pick E2E changes #28648
+630
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
reviewed
Nov 22, 2024
gambinish
reviewed
Nov 22, 2024
Comment on lines
+124
to
+148
| it('switches networks when clicking on swap for a token on another network', async function () { | ||
| await withFixtures( | ||
| buildFixtures(this.test?.fullTitle() as string), | ||
| async ({ | ||
| driver, | ||
| ganacheServer, | ||
| }: { | ||
| driver: Driver; | ||
| ganacheServer?: Ganache; | ||
| }) => { | ||
| await loginWithBalanceValidation(driver, ganacheServer); | ||
| const assetListPage = new AssetListPage(driver); | ||
| await assetListPage.waitUntilAssetListHasItems(4); | ||
| await assetListPage.clickOnAsset('LineaETH'); | ||
| await driver.clickElement('[data-testid="token-overview-button-swap"]'); | ||
| const toastTextElement = await driver.findElement('.toast-text'); | ||
| const toastText = await toastTextElement.getText(); | ||
| assert.equal( | ||
| toastText, | ||
| "You're now using Linea Sepolia", | ||
| 'Toast text is correct', | ||
| ); | ||
| }, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
If we do end up doing a try/catch, or some sort of error handling on the client to prevent the "network switch failure" case, I'd imagine that we'd probably add some additional e2e tests here as well.
jonybur
changed the base branch from
feat/mmassets-432_network-filter-extension--integration-balances
to
develop
jonybur
changed the base branch from
develop
to
feat/mmassets-432_network-filter-extension--integration-balances
jonybur
deleted the
feat/mmassets-432_network-filter-extension--integration-balances--e2e-tests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist