fix: add unit test for assets polling loops #28646
Merged
+588
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [e5f3894]
Page Load Metrics (1996 ± 86 ms)
Bundle size diffs
|
darkwing
reviewed
Nov 22, 2024
darkwing
reviewed
Nov 22, 2024
salimtb
force-pushed
the
salim/add-unit-test-for-polling-loops
branch
from
5c5b246 to
71fce30
Compare
gambinish
reviewed
Nov 22, 2024
Comment on lines
+21
to
+33
| beforeEach(() => { | ||
| // Mock process.env.PORTFOLIO_VIEW | ||
| originalPortfolioView = process.env.PORTFOLIO_VIEW; | ||
| process.env.PORTFOLIO_VIEW = 'true'; // Set your desired mock value here | ||
|
|
||
| mockPromises = []; | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| // Restore the original value | ||
| process.env.PORTFOLIO_VIEW = originalPortfolioView; | ||
| }); |
There was a problem hiding this comment.
Will these need to be removed once we nuke the feature flag from the codebase?
gambinish
reviewed
Nov 22, 2024
| }); | ||
|
|
||
| it('should poll token detection for chain IDs when enabled and stop on dismount', async () => { | ||
| process.env.PORTFOLIO_VIEW = 'true'; |
gambinish
reviewed
Nov 22, 2024
Comment on lines
+21
to
+33
| beforeEach(() => { | ||
| // Mock process.env.PORTFOLIO_VIEW | ||
| originalPortfolioView = process.env.PORTFOLIO_VIEW; | ||
| process.env.PORTFOLIO_VIEW = 'true'; // Set your desired mock value here | ||
|
|
||
| mockPromises = []; | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| // Restore the original value | ||
| process.env.PORTFOLIO_VIEW = originalPortfolioView; | ||
| }); |
gambinish
approved these changes
Nov 22, 2024
Builds ready [71fce30]
Page Load Metrics (1625 ± 46 ms)
Bundle size diffs
|
sahar-fehri
approved these changes
Nov 22, 2024
metamaskbot
added
the
release-12.9.0
salimtb
added
the
portfolio-view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the goal of this PR is to add unit tests for all multichain assets polling loops
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist